[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] target/xtensa: clean up unaligned access
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v4] target/xtensa: clean up unaligned access |
|
Date: |
Wed, 19 May 2021 16:19:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/19/21 12:45 PM, Max Filippov wrote:
> Xtensa cores may or may not have hardware support for unaligned memory
> access. Remove TARGET_ALIGNED_ONLY=y from all xtensa configurations and
> pass MO_ALIGN in memory access flags for all operations that would raise
> an exception.
> Simplify use of gen_load_store_alignment by passing access size and
> alignment requirements in single parameter.
> Drop condition from xtensa_cpu_do_unaligned_access and replace it with
> assertion.
> Add a test.
>
> Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
Based-on: <20210519104433.16870-1-jcmvbkbc@gmail.com>
> create mode 100644 tests/tcg/xtensa/test_load_store.S
Except this asm file,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Thanks!