[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO ->
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC |
|
Date: |
Wed, 19 May 2021 13:05:47 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/19/21 10:23 AM, Thomas Huth wrote:
> On 18/05/2021 21.32, Philippe Mathieu-Daudé wrote:
>> isa_superio_realize() calls isa_fdc_init_drives(), which is defined
>> in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol.
>
> If I get that right, not all superio chipsets provide a floppy drive
> (there's this "k->floppy.is_enabled" check in there) ... but for boards
> that don't need the FDC, this would currently require a stub for that
> function
Good point. I'll try to get it right.
- [PATCH v5 0/6] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers, Philippe Mathieu-Daudé, 2021/05/18
- [PATCH v5 2/6] hw/block/fdc: Replace disabled fprintf() by trace event, Philippe Mathieu-Daudé, 2021/05/18
- [PATCH v5 3/6] hw/block/fdc: Declare shared prototypes in fdc-internal.h, Philippe Mathieu-Daudé, 2021/05/18
- [PATCH v5 4/6] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c, Philippe Mathieu-Daudé, 2021/05/18
- [PATCH v5 5/6] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c, Philippe Mathieu-Daudé, 2021/05/18
- [PATCH v5 6/6] hw/block/fdc: Add sysbus_fdc_init_drives() method, Philippe Mathieu-Daudé, 2021/05/18