[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/7] virtiofsd: Get rid of unreachable code in read
From: |
Vivek Goyal |
Subject: |
[PATCH v2 2/7] virtiofsd: Get rid of unreachable code in read |
Date: |
Tue, 18 May 2021 17:35:33 -0400 |
pvreadv() can return following.
- error
- 0 in case of EOF
- short read
We seem to handle all the cases already. We are retrying read in case
of short read. So another check for short read seems like dead code.
Get rid of it.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
tools/virtiofsd/fuse_virtio.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index 755d7fb25c..28e2974d1a 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -446,11 +446,6 @@ int virtio_send_data_iov(struct fuse_session *se, struct
fuse_chan *ch,
in_sg_left);
break;
}
- if (ret != len) {
- fuse_log(FUSE_LOG_DEBUG, "%s: ret!=len\n", __func__);
- ret = EIO;
- goto err;
- }
in_sg_left -= ret;
len -= ret;
} while (in_sg_left);
--
2.25.4
- [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(), Vivek Goyal, 2021/05/18
- [PATCH v2 4/7] virtiofsd: get rid of in_sg_left variable, Vivek Goyal, 2021/05/18
- [PATCH v2 6/7] virtiofsd: Check EOF before short read, Vivek Goyal, 2021/05/18
- [PATCH v2 2/7] virtiofsd: Get rid of unreachable code in read,
Vivek Goyal <=
- [PATCH v2 7/7] virtiofsd: Set req->reply_sent right after sending reply, Vivek Goyal, 2021/05/18
- [PATCH v2 3/7] virtiofsd: Use iov_discard_front() to skip bytes, Vivek Goyal, 2021/05/18
- [PATCH v2 1/7] virtiofsd: Check for EINTR in preadv() and retry, Vivek Goyal, 2021/05/18
- [PATCH v2 5/7] virtiofsd: Simplify skip byte logic, Vivek Goyal, 2021/05/18
- Re: [PATCH v2 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(), Dr. David Alan Gilbert, 2021/05/25