[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] virtiofsd: Check for EINTR in preadv() and retry
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 1/7] virtiofsd: Check for EINTR in preadv() and retry |
Date: |
Tue, 18 May 2021 12:59:31 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
* Vivek Goyal (vgoyal@redhat.com) wrote:
> We don't seem to check for EINTR and retry. There are other places
> in code where we check for EINTR. So lets add a check.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index 1170f375a5..32914f7e95 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -421,6 +421,9 @@ int virtio_send_data_iov(struct fuse_session *se, struct
> fuse_chan *ch,
>
> if (ret == -1) {
> ret = errno;
> + if (ret == EINTR) {
> + continue;
> + }
> fuse_log(FUSE_LOG_DEBUG, "%s: preadv failed (%m) len=%zd\n",
> __func__, len);
> goto err;
> --
> 2.25.4
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(), Vivek Goyal, 2021/05/11
- [PATCH 5/7] virtiofsd: Simplify skip byte logic, Vivek Goyal, 2021/05/11
- [PATCH 1/7] virtiofsd: Check for EINTR in preadv() and retry, Vivek Goyal, 2021/05/11
- Re: [PATCH 1/7] virtiofsd: Check for EINTR in preadv() and retry,
Dr. David Alan Gilbert <=
- [PATCH 4/7] virtiofsd: get rid of in_sg_left variable, Vivek Goyal, 2021/05/11
- [PATCH 3/7] virtiofsd: Use iov_discard_front() to skip bytes, Vivek Goyal, 2021/05/11
- [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply, Vivek Goyal, 2021/05/11
- Re: [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply, Dr. David Alan Gilbert, 2021/05/18
- [PATCH 6/7] virtiofsd: Check EOF before short read, Vivek Goyal, 2021/05/11