Re: [PATCH v2 18/50] target/i386: Move rex

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 18/50] target/i386: Move rex_w into DisasContext

From:	Paolo Bonzini
Subject:	Re: [PATCH v2 18/50] target/i386: Move rex_w into DisasContext
Date:	Tue, 18 May 2021 11:30:12 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 14/05/21 17:13, Richard Henderson wrote:

Treat this flag exactly like we treat the other rex bits.
The -1 initialization is unused; the two tests are > 0 and == 1,
so the value can be reduced to a bool.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 17/50] target/i386: Move rex_r into DisasContext, (continued)
- [PATCH v2 19/50] target/i386: Remove DisasContext.f_st as unused, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 19/50] target/i386: Remove DisasContext.f_st as unused, Paolo Bonzini, 2021/05/18
- [PATCH v2 20/50] target/i386: Reduce DisasContext.flags to uint32_t, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 20/50] target/i386: Reduce DisasContext.flags to uint32_t, Paolo Bonzini, 2021/05/18
- [PATCH v2 21/50] target/i386: Reduce DisasContext.override to int8_t, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 21/50] target/i386: Reduce DisasContext.override to int8_t, Paolo Bonzini, 2021/05/18
- [PATCH v2 26/50] target/i386: Reduce DisasContext jmp_opt, repz_opt to bool, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 26/50] target/i386: Reduce DisasContext jmp_opt, repz_opt to bool, Paolo Bonzini, 2021/05/18
- [PATCH v2 18/50] target/i386: Move rex_w into DisasContext, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 18/50] target/i386: Move rex_w into DisasContext, Paolo Bonzini <=
- [PATCH v2 27/50] target/i386: Fix the comment for repz_opt, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 27/50] target/i386: Fix the comment for repz_opt, Paolo Bonzini, 2021/05/18
- [PATCH v2 32/50] target/i386: Implement skinit in translate.c, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 32/50] target/i386: Implement skinit in translate.c, Paolo Bonzini, 2021/05/18
- [PATCH v2 31/50] target/i386: Assert !GUEST for user-only, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 31/50] target/i386: Assert !GUEST for user-only, Paolo Bonzini, 2021/05/18
- [PATCH v2 33/50] target/i386: Eliminate SVM helpers for user-only, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 33/50] target/i386: Eliminate SVM helpers for user-only, Paolo Bonzini, 2021/05/18
- [PATCH v2 24/50] target/i386: Reduce DisasContext popl_esp_hack and rip_offset to uint8_t, Richard Henderson, 2021/05/14
  - Re: [PATCH v2 24/50] target/i386: Reduce DisasContext popl_esp_hack and rip_offset to uint8_t, Paolo Bonzini, 2021/05/18

Prev by Date: Re: [PATCH v2 17/50] target/i386: Move rex_r into DisasContext
Next by Date: Re: [PATCH v2 19/50] target/i386: Remove DisasContext.f_st as unused
Previous by thread: [PATCH v2 18/50] target/i386: Move rex_w into DisasContext
Next by thread: [PATCH v2 27/50] target/i386: Fix the comment for repz_opt
Index(es):
- Date
- Thread