Re: [PATCH] hw/display/qxl: Set pci rom address aligned with page size

[maobibo]

在 2021年05月18日 15:03, Gerd Hoffmann 写道:
> On Tue, May 18, 2021 at 09:06:31AM +0800, maobibo wrote:
>> Sorry I do not state the background clearly.
>>
>> Page size is 16K on my MIPS machine, and it supports running
>> guest OS in kvm mode and qxl vga card can used for VM.
> 
> Ok.  Please add that to the commit message.
> 
> Also there is no need to rewrite the function and drop the
> BUILD_BUG_ON().  Just using "return QEMU_ALIGN_UP(QXL_ROM_SZ, pagesize)"
> should work fine.
ok, I will refresh the patch.

> 
> Is the host page size fixed on mips?

No, it is not fixed on mips, and it can be selected by linux kernel config.

regards
bibo, mao
> 
> take care,
>   Gerd
>