[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 6/6] python/machine: disable warning for Popen in _launch()
From: |
John Snow |
Subject: |
[PATCH v2 6/6] python/machine: disable warning for Popen in _launch() |
Date: |
Mon, 17 May 2021 14:48:08 -0400 |
We handle this resource rather meticulously in
shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in
_do_shutdown().
Quiet this pylint warning here.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/python/qemu/machine.py b/python/qemu/machine.py
index f021127f0fc..06058d89e83 100644
--- a/python/qemu/machine.py
+++ b/python/qemu/machine.py
@@ -407,6 +407,9 @@ def _launch(self) -> None:
self._args)
)
LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args))
+
+ # Cleaning up of this subprocess is guaranteed by _do_shutdown.
+ # pylint: disable=consider-using-with
self._popen = subprocess.Popen(self._qemu_full_args,
stdin=subprocess.DEVNULL,
stdout=self._qemu_log_file,
--
2.30.2
- [PATCH v2 0/6] Python: delint python library, John Snow, 2021/05/17
- [PATCH v2 1/6] python/console_socket: avoid one-letter variable, John Snow, 2021/05/17
- [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull), John Snow, 2021/05/17
- [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen, John Snow, 2021/05/17
- [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch, John Snow, 2021/05/17
- [PATCH v2 6/6] python/machine: disable warning for Popen in _launch(),
John Snow <=
- [PATCH v2 4/6] python/console_socket: Add a pylint ignore, John Snow, 2021/05/17
- Re: [PATCH v2 0/6] Python: delint python library, John Snow, 2021/05/18