Re: [PATCH v3 3/8] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c

[Philippe Mathieu-Daudé]

On 5/17/21 8:19 PM, John Snow wrote:
> On 5/17/21 2:04 PM, John Snow wrote:
>> On 5/17/21 1:49 PM, Philippe Mathieu-Daudé wrote:
>>> Some machines use floppy controllers via the SysBus interface,
>>> and don't need to pull in all the ISA code.
>>> Extract the ISA specific code to a new unit: fdc-isa.c, and
>>> add a new Kconfig symbol: "FDC_ISA".
>>>
>>> Reviewed-by: John Snow <jsnow@redhat.com>
>>> Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>> Sorry, I'm seeing build failures on this for patch #03:
>>
>> ../../configure --enable-docs; and make -j13
>>
>> ...
>>
>> /usr/bin/ld: libcommon.fa.p/hw_isa_isa-superio.c.o: in function
>> `isa_superio_realize':
>> /home/jsnow/src/qemu/bin/git/../../hw/isa/isa-superio.c:132: undefined
>> reference to `isa_fdc_init_drives'
>> collect2: error: ld returned 1 exit status
>>
>>
> 
> It appears to show up if you enable the mips-softmmu target.

Sorry, fixed in v4...