Re: [PATCH v2] vhost-vdpa: Remove redundant declaration of address_space_memory

[Stefano Garzarella]

On Mon, May 17, 2021 at 08:32:46PM +0800, Xie Yongji wrote:
> The symbol address_space_memory are already declared in
> include/exec/address-spaces.h. So let's add this header file
> and remove the redundant declaration in include/hw/virtio/vhost-vdpa.h.
>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/virtio/vhost-vdpa.c         | 1 +
> include/hw/virtio/vhost-vdpa.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 8f2fb9f10b2a..ee51863d280b 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -18,6 +18,7 @@
> #include "hw/virtio/vhost-backend.h"
> #include "hw/virtio/virtio-net.h"
> #include "hw/virtio/vhost-vdpa.h"
> +#include "exec/address-spaces.h"
> #include "qemu/main-loop.h"
> #include "cpu.h"
> #include "trace.h"
> diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
> index 28ca65018ed7..ae9ee7adb2d0 100644
> --- a/include/hw/virtio/vhost-vdpa.h
> +++ b/include/hw/virtio/vhost-vdpa.h
> @@ -21,5 +21,4 @@ typedef struct vhost_vdpa {
>     struct vhost_dev *dev;
> } VhostVDPA;
>
> -extern AddressSpace address_space_memory;
> #endif
> --
> 2.11.0

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>