[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main()
From: |
Cornelia Huck |
Subject: |
Re: [PATCH 3/3] pc-bios/s390-ccw: Add a proper prototype for main() |
Date: |
Mon, 17 May 2021 18:22:32 +0200 |
On Wed, 12 May 2021 19:15:50 +0200
Thomas Huth <thuth@redhat.com> wrote:
> Older versions of Clang complain if there is no prototype for main().
> Add one, and while we're at it, make sure that we use the same type
> for main.c and netmain.c - since the return value does not matter,
> declare the return type of main() as "void".
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/main.c | 3 +--
> pc-bios/s390-ccw/s390-ccw.h | 1 +
> 2 files changed, 2 insertions(+), 2 deletions(-)
It's probably not strictly needed for both to have the same prototype,
but this looks sane to me.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>