qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 50/72] softfloat: Move minmax_flags to softfloat-parts.c.inc


From: Richard Henderson
Subject: Re: [PATCH 50/72] softfloat: Move minmax_flags to softfloat-parts.c.inc
Date: Mon, 17 May 2021 10:57:37 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/17/21 8:14 AM, David Hildenbrand wrote:
This patch introduces two issues:

1. Comparing two negative numbers is broken. We have to
invert the a_less result.

2. The check "flags & minmax_ismag" is broken because
"minmax_ismag = 4 | minmax_isnum" and it, therefore,
also triggers for "flags = minmax_isnum"

Thanks. I guess I should assume from this that these tests are not enabled, and I should fix that as well.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]