[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Virtio-fs] [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_
From: |
Vivek Goyal |
Subject: |
Re: [Virtio-fs] [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov() |
Date: |
Mon, 17 May 2021 09:08:50 -0400 |
On Thu, May 13, 2021 at 03:50:33PM -0500, Connor Kuehl wrote:
> On 5/11/21 4:37 PM, Vivek Goyal wrote:
> > Hi,
> >
> > Code in virtio_send_data_iov() little twisted and complicated. This
> > patch series just tries to simplify it a bit to make it little easier
> > to read this piece of code.
> >
> > Thanks
> > Vivek
> >
> > Vivek Goyal (7):
> > virtiofsd: Check for EINTR in preadv() and retry
> > virtiofsd: Get rid of unreachable code in read
> > virtiofsd: Use iov_discard_front() to skip bytes
> > virtiofsd: get rid of in_sg_left variable
> > virtiofsd: Simplify skip byte logic
> > virtiofsd: Check EOF before short read
> > virtiofsd: Set req->reply_sent right after sending reply
> >
> > tools/virtiofsd/fuse_virtio.c | 67 +++++++++++------------------------
> > 1 file changed, 21 insertions(+), 46 deletions(-)
> >
>
> With the codestyle fix to appease the bot:
>
> Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
>
> (For the series)
Thanks. I will fix the coding style issue and repost the patch series.
Vivek
- [PATCH 1/7] virtiofsd: Check for EINTR in preadv() and retry, (continued)
- [PATCH 1/7] virtiofsd: Check for EINTR in preadv() and retry, Vivek Goyal, 2021/05/11
- [PATCH 4/7] virtiofsd: get rid of in_sg_left variable, Vivek Goyal, 2021/05/11
- [PATCH 3/7] virtiofsd: Use iov_discard_front() to skip bytes, Vivek Goyal, 2021/05/11
- [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply, Vivek Goyal, 2021/05/11
- [PATCH 6/7] virtiofsd: Check EOF before short read, Vivek Goyal, 2021/05/11
- [PATCH 2/7] virtiofsd: Get rid of unreachable code in read, Vivek Goyal, 2021/05/11
- Re: [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(), no-reply, 2021/05/11
- Re: [Virtio-fs] [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(), Connor Kuehl, 2021/05/13
- Re: [Virtio-fs] [PATCH 0/7] virtiofsd: Few cleanups in virtio_send_data_iov(),
Vivek Goyal <=