[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 03/15] accel/hax: Simplify #ifdef'ry
From: |
Philippe Mathieu-Daudé |
Subject: |
[RFC PATCH 03/15] accel/hax: Simplify #ifdef'ry |
Date: |
Mon, 17 May 2021 13:55:13 +0200 |
hax_enabled() is called from:
- qemu_init_board() in softmmu/vl.c
- qemu_wait_io_event() in softmmu/cpus.c
- apic_common_realize() in hw/intc/apic_common.c
By converting macros to a function, we can remove the
NEED_CPU_H dependency and build softmmu/cpus.c once
for all targets.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/sysemu/hax.h | 14 +-------------
accel/stubs/hax-stub.c | 5 +++++
target/i386/hax/hax-all.c | 2 +-
3 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/include/sysemu/hax.h b/include/sysemu/hax.h
index 247f0661d12..bc165b23ae6 100644
--- a/include/sysemu/hax.h
+++ b/include/sysemu/hax.h
@@ -24,18 +24,6 @@
int hax_sync_vcpus(void);
-#ifdef NEED_CPU_H
-
-#ifdef CONFIG_HAX
-
-int hax_enabled(void);
-
-#else /* CONFIG_HAX */
-
-#define hax_enabled() (0)
-
-#endif /* CONFIG_HAX */
-
-#endif /* NEED_CPU_H */
+bool hax_enabled(void);
#endif /* QEMU_HAX_H */
diff --git a/accel/stubs/hax-stub.c b/accel/stubs/hax-stub.c
index 49077f88e3c..1a0370a4362 100644
--- a/accel/stubs/hax-stub.c
+++ b/accel/stubs/hax-stub.c
@@ -16,6 +16,11 @@
#include "qemu/osdep.h"
#include "sysemu/hax.h"
+bool hax_enabled(void)
+{
+ return false;
+}
+
int hax_sync_vcpus(void)
{
return 0;
diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c
index bf65ed6fa92..d99feef21d4 100644
--- a/target/i386/hax/hax-all.c
+++ b/target/i386/hax/hax-all.c
@@ -56,7 +56,7 @@ struct hax_state hax_global;
static void hax_vcpu_sync_state(CPUArchState *env, int modified);
static int hax_arch_get_registers(CPUArchState *env);
-int hax_enabled(void)
+bool hax_enabled(void)
{
return hax_allowed;
}
--
2.26.3
- [RFC PATCH 00/15] softmmu: Make various objects target agnostic, Philippe Mathieu-Daudé, 2021/05/17
- [RFC PATCH 01/15] accel/kvm: Add more stubs, Philippe Mathieu-Daudé, 2021/05/17
- [RFC PATCH 02/15] accel/whpx: Simplify #ifdef'ry, Philippe Mathieu-Daudé, 2021/05/17
- [RFC PATCH 03/15] accel/hax: Simplify #ifdef'ry,
Philippe Mathieu-Daudé <=
- [RFC PATCH 04/15] accel: Only use TCG when building user-mode emulation, Philippe Mathieu-Daudé, 2021/05/17
- [RFC PATCH 05/15] accel/kvm: Simplify user-mode #ifdef'ry, Philippe Mathieu-Daudé, 2021/05/17
- [RFC PATCH 06/15] hw/acpi/memory_hotplug: Remove unused 'hw/acpi/pc-hotplug.h' header, Philippe Mathieu-Daudé, 2021/05/17
- [RFC PATCH 08/15] softmmu/cpu-timers: Remove unused 'exec/exec-all.h' header, Philippe Mathieu-Daudé, 2021/05/17
- [RFC PATCH 09/15] softmmu/runstate: Clean headers, Philippe Mathieu-Daudé, 2021/05/17