|
From: | Richard Henderson |
Subject: | Re: [PATCH] accel/tcg: Align data dumped at end of TB |
Date: | Sun, 16 May 2021 09:01:39 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/15/21 5:42 AM, Philippe Mathieu-Daudé wrote:
+ qemu_log("0x%08" PRIxPTR ": .quad 0x%0*" TCG_PRIlx "\n", + (uintptr_t)&rx_data_gen_ptr[i], + 2 * sizeof(tcg_target_ulong), rx_data_gen_ptr[i]);
This doesn't quite work, because
../qemu/accel/tcg/translate-all.c:2045:26: error: field width specifier ‘*’ expects argument of type ‘int’, but argument 3 has type ‘long unsigned int’ [-Werror=format=] 2045 | qemu_log("0x%08" PRIxPTR ": .quad 0x%0*" TCG_PRIlx "\n", | ^~~~~~~ 2046 | (uintptr_t)&rx_data_gen_ptr[i], 2047 | 2 * sizeof(tcg_target_ulong), rx_data_gen_ptr[i]); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | long unsigned int
However, I also noticed that we shouldn't be printing ".quad" for 32-bit hosts either. So I'll just split this into two separate qemu_log invocations, based on sizeof(tcg_target_ulong).
r~
[Prev in Thread] | Current Thread | [Next in Thread] |