[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/20] util/compatfd.c: Replaced a malloc call with g_malloc.
From: |
Thomas Huth |
Subject: |
[PULL 08/20] util/compatfd.c: Replaced a malloc call with g_malloc. |
Date: |
Fri, 14 May 2021 14:15:06 +0200 |
From: Mahmoud Mandour <ma.mandourr@gmail.com>
Replaced a call to malloc() and its respective call to free()
with g_malloc() and g_free().
g_malloc() is preferred more than g_try_* functions, which
return NULL on error, when the size of the requested
allocation is small. This is because allocating few
bytes should not be a problem in a healthy system.
Otherwise, the system is already in a critical state.
Subsequently, removed NULL-checking after g_malloc().
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Message-Id: <20210315105814.5188-3-ma.mandourr@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
util/compatfd.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/util/compatfd.c b/util/compatfd.c
index 174f394533..a8ec525c6c 100644
--- a/util/compatfd.c
+++ b/util/compatfd.c
@@ -72,14 +72,10 @@ static int qemu_signalfd_compat(const sigset_t *mask)
QemuThread thread;
int fds[2];
- info = malloc(sizeof(*info));
- if (info == NULL) {
- errno = ENOMEM;
- return -1;
- }
+ info = g_malloc(sizeof(*info));
if (pipe(fds) == -1) {
- free(info);
+ g_free(info);
return -1;
}
--
2.27.0
- [PULL 02/20] gitlab-ci: Replace YAML anchors by extends (container_job), (continued)
- [PULL 02/20] gitlab-ci: Replace YAML anchors by extends (container_job), Thomas Huth, 2021/05/14
- [PULL 01/20] tests/docker/dockerfiles: Add ccache to containers where it was missing, Thomas Huth, 2021/05/14
- [PULL 03/20] gitlab-ci: Replace YAML anchors by extends (native_build_job), Thomas Huth, 2021/05/14
- [PULL 04/20] gitlab-ci: Replace YAML anchors by extends (native_test_job), Thomas Huth, 2021/05/14
- [PULL 05/20] libqos/qgraph: fix "UNAVAILBLE" typo, Thomas Huth, 2021/05/14
- [PULL 07/20] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm, Thomas Huth, 2021/05/14
- [PULL 06/20] docs/devel/qgraph: add troubleshooting information, Thomas Huth, 2021/05/14
- [PULL 10/20] tests/qtest/npcm7xx_pwm-test.c: Avoid g_assert_true() for non-test assertions, Thomas Huth, 2021/05/14
- [PULL 11/20] tests/migration-test: Fix "true" vs true, Thomas Huth, 2021/05/14
- [PULL 09/20] tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic, Thomas Huth, 2021/05/14
- [PULL 08/20] util/compatfd.c: Replaced a malloc call with g_malloc.,
Thomas Huth <=
- [PULL 13/20] tests/qtest/rtc-test: Remove pointless NULL check, Thomas Huth, 2021/05/14
- [PULL 17/20] configure: Poison all current target-specific #defines, Thomas Huth, 2021/05/14
- [PULL 14/20] tests: Avoid side effects inside g_assert() arguments, Thomas Huth, 2021/05/14
- [PULL 15/20] include/sysemu: Poison all accelerator CONFIG switches in common code, Thomas Huth, 2021/05/14
- [PULL 16/20] migration: Move populate_vfio_info() into a separate file, Thomas Huth, 2021/05/14
- [PULL 12/20] tests/qtest/tpm-util.c: Free memory with correct free function, Thomas Huth, 2021/05/14
- [PULL 19/20] pc-bios/s390-ccw: Fix inline assembly for older versions of Clang, Thomas Huth, 2021/05/14
- [PULL 18/20] tests/qtest/migration-test: Use g_autofree to avoid leaks on error paths, Thomas Huth, 2021/05/14