[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/17] numa: Make all callbacks of ram block notifiers optional
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 07/17] numa: Make all callbacks of ram block notifiers optional |
Date: |
Thu, 13 May 2021 18:37:27 +0100 |
From: David Hildenbrand <david@redhat.com>
Let's make add/remove optional. We want to introduce a RAM block
notifier for RAM migration that is only interested in resize events.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210429112708.12291-4-david@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/core/numa.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/core/numa.c b/hw/core/numa.c
index 4c58b2348d..1058d3697b 100644
--- a/hw/core/numa.c
+++ b/hw/core/numa.c
@@ -818,8 +818,11 @@ static int ram_block_notify_add_single(RAMBlock *rb, void
*opaque)
void ram_block_notifier_add(RAMBlockNotifier *n)
{
QLIST_INSERT_HEAD(&ram_list.ramblock_notifiers, n, next);
+
/* Notify about all existing ram blocks. */
- qemu_ram_foreach_block(ram_block_notify_add_single, n);
+ if (n->ram_block_added) {
+ qemu_ram_foreach_block(ram_block_notify_add_single, n);
+ }
}
void ram_block_notifier_remove(RAMBlockNotifier *n)
@@ -832,7 +835,9 @@ void ram_block_notify_add(void *host, size_t size, size_t
max_size)
RAMBlockNotifier *notifier;
QLIST_FOREACH(notifier, &ram_list.ramblock_notifiers, next) {
- notifier->ram_block_added(notifier, host, size, max_size);
+ if (notifier->ram_block_added) {
+ notifier->ram_block_added(notifier, host, size, max_size);
+ }
}
}
@@ -841,7 +846,9 @@ void ram_block_notify_remove(void *host, size_t size,
size_t max_size)
RAMBlockNotifier *notifier;
QLIST_FOREACH(notifier, &ram_list.ramblock_notifiers, next) {
- notifier->ram_block_removed(notifier, host, size, max_size);
+ if (notifier->ram_block_removed) {
+ notifier->ram_block_removed(notifier, host, size, max_size);
+ }
}
}
--
2.31.1
- Re: [PULL 00/17] migration queue, (continued)
- [PULL 00/17] migration queue, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 01/17] migrate/ram: remove "ram_bulk_stage" and "fpo_enabled", Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 02/17] migration/ram: Reduce unnecessary rate limiting, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 03/17] migration/ram: Optimize ram_save_host_page(), Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 04/17] migration: Drop redundant query-migrate result @blocked, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 05/17] util: vfio-helpers: Factor out and fix processing of existing ram blocks, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 06/17] numa: Teach ram block notifiers about resizeable ram blocks, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 07/17] numa: Make all callbacks of ram block notifiers optional,
Dr. David Alan Gilbert (git) <=
- [PULL 08/17] migration/ram: Handle RAM block resizes during precopy, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 10/17] migration/ram: Discard RAM when growing RAM blocks after ram_postcopy_incoming_init(), Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 09/17] exec: Relax range check in ram_block_discard_range(), Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 11/17] migration/ram: Simplify host page handling in ram_load_postcopy(), Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 13/17] migration/multifd: Print used_length of memory block, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 12/17] migration/ram: Handle RAM block resizes during postcopy, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 14/17] migration/ram: Use offset_in_ramblock() in range checks, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 15/17] tests/migration-test: Fix "true" vs true, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 16/17] tests/qtest/migration-test: Use g_autofree to avoid leaks on error paths, Dr. David Alan Gilbert (git), 2021/05/13
- [PULL 17/17] tests/migration: introduce multifd into guestperf, Dr. David Alan Gilbert (git), 2021/05/13