[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV |
Date: |
Thu, 13 May 2021 18:38:50 +0200 |
The pci_ide_create_devs() function is declared i hw/ide/qdev.c:
$ git grep ide_create_drive
hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i],
hd_table[i]);
hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo
*drive)
include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int
unit, DriveInfo *drive);
Fix the correct symbol dependency to avoid build failure when
deselecting some machines:
/usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_devs':
hw/ide/pci.c:491: undefined reference to `ide_create_drive'
Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/ide/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig
index 8e2c8934549..dd85fa3619f 100644
--- a/hw/ide/Kconfig
+++ b/hw/ide/Kconfig
@@ -8,7 +8,7 @@ config IDE_QDEV
config IDE_PCI
bool
depends on PCI
- select IDE_CORE
+ select IDE_QDEV
config IDE_ISA
bool
--
2.26.3
- [PATCH 00/10] hw: Various Kconfig fixes, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 01/10] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on', Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV,
Philippe Mathieu-Daudé <=
- [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 05/10] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 04/10] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board, Philippe Mathieu-Daudé, 2021/05/13
- [PATCH 06/10] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL, Philippe Mathieu-Daudé, 2021/05/13