Re: [PATCH v3 09/22] tests/docker: fix mistakes in ubuntu package lists

[Daniel P . Berrangé]

On Thu, May 13, 2021 at 12:12:33PM +0200, Philippe Mathieu-Daudé wrote:
> On 5/13/21 11:55 AM, Daniel P. Berrangé wrote:
> > librados-dev is not required by QEMU directly, only librbd-dev.
> > 
> > glusterfs-common is not directly needed by QEMU.
> > 
> > QEMU uses ncursesw only on non-Windows hosts.
> > 
> > The clang package is clang 10.
> > 
> > flex and bison are not required by QEMU.
> 
> I included them to use the same Docker file to build Linux kernel
> we test. Not a blocker, this is the QEMU project, and I'd rather
> get the vmlinux images prebuilt from elsewhere, so:

If we want containers in which we can build the kernel, we can
also create a dedicated set of dockerfiles containing only the
deps that Linux kernel builds needs, separate from QEMU. 

> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> > Standardize on nmap ncat implementation to match Fedora/CentOS.
> > 
> > Remove vim since it is not a build pre-requisite and no other containers
> > include it.
> > 
> > Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  tests/docker/dockerfiles/ubuntu1804.docker |  3 ---
> >  tests/docker/dockerfiles/ubuntu2004.docker | 10 ++--------
> >  2 files changed, 2 insertions(+), 11 deletions(-)
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|