|
| From: | Max Reitz |
| Subject: | Re: [PATCH v2] qemu-iotests: fix pylint 2.8 consider-using-with error |
| Date: | Wed, 12 May 2021 19:04:44 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 10.05.21 21:04, Emanuele Giuseppe Esposito wrote:
pylint 2.8 introduces consider-using-with error, suggesting to use the 'with' block statement when possible. Modify all subprocess.Popen call to use the 'with' statement, except the one in __init__ of QemuIoInteractive class, since it is assigned to a class field and used in other methods. Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> --- v1 -> v2: * fix indentation [Max] * explain why we disabled the check in QemuIoInteractive's __init__ [Max]
Thanks! Applied to my block branch: https://github.com/XanClic/qemu/commits/block Max
| [Prev in Thread] | Current Thread | [Next in Thread] |