Re: [PATCH 2/2] net/tap: fix error reporting when bridge helper forgets to send an FD

[Daniel P . Berrangé]

On Tue, May 11, 2021 at 01:53:39PM -0500, Connor Kuehl wrote:
> On 5/5/21 7:12 AM, Daniel P. Berrangé wrote:
> > [..]
> > The recv_fd() method returns -1 on error, 0 on end of file, or an FD
> >   $ qemu-system-x86_64 -netdev bridge,br=br99,helper=/bin/true,id=ns0
> >   qemu-system-x86_64: -netdev bridge,br=br99,helper=/bin/true,id=ns0:
> >     bridge helper did not send a file descriptor
> > [..]
> >          }
> > +
> > +        /*
> > +         * ret == 0 means EOF, and if status == 0 then helper
> > +         * exited cleanly but forgot to send us an FD. Opps...
> > +         */
> > +        if (ret == 0) {
> > +            error_setg(errp, "bridge helper did not send a file
> > descriptor");
> 
> Is it possible to include the name of the helper that's at fault here?
> Could be helpful for debugging if the command line includes multiple
> netdev opts with a helper parameter (unless that's literally impossible).

Yes, easy change.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|