Re: [PATCH] 9pfs: add link to 9p developer docs

[Greg Kurz]

On Wed, 12 May 2021 12:25:56 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:

> On Dienstag, 11. Mai 2021 21:57:53 CEST Connor Kuehl wrote:
> > On 5/6/21 8:12 AM, Christian Schoenebeck wrote:
> > > To lower the entry level for new developers, add a link to the
> > > 9p developer docs (i.e. qemu wiki) at the beginning of 9p source
> > > files, that is to: https://wiki.qemu.org/Documentation/9p
> > > 
> > > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > > ---
> > > 
> > >  hw/9pfs/9p-local.c             | 5 +++++
> > >  hw/9pfs/9p-posix-acl.c         | 5 +++++
> > >  hw/9pfs/9p-proxy.c             | 5 +++++
> > >  hw/9pfs/9p-synth.c             | 5 +++++
> > >  hw/9pfs/9p-util.c              | 5 +++++
> > >  hw/9pfs/9p-xattr-user.c        | 5 +++++
> > >  hw/9pfs/9p-xattr.c             | 5 +++++
> > >  hw/9pfs/9p.c                   | 5 +++++
> > >  hw/9pfs/codir.c                | 5 +++++
> > >  hw/9pfs/cofile.c               | 5 +++++
> > >  hw/9pfs/cofs.c                 | 5 +++++
> > >  hw/9pfs/coth.c                 | 5 +++++
> > >  hw/9pfs/coxattr.c              | 5 +++++
> > >  hw/9pfs/virtio-9p-device.c     | 5 +++++
> > >  hw/9pfs/xen-9p-backend.c       | 5 +++++
> > >  tests/qtest/libqos/virtio-9p.c | 5 +++++
> > >  tests/qtest/virtio-9p-test.c   | 5 +++++
> > 
> > Would it be helpful to also add this link to the virtio-9p stanza in
> > MAINTAINERS? Something like:
> > 
> > W: https://wiki.qemu.org/Documentation/9p
> > 
> > Connor
> 
> Right, makes sense to me. I think I can just handle that as a separate patch 
> subsequently, not worth a threaded V2 IMO.
> 
> @Greg: a humble PING from the silent 9p front.
> 

Sorry for lack of care... I agree both with the patch and with
Connor's suggestion. No need to even post anything more. You
can just fix this patch in your tree.

Acked-by: Greg Kurz <groug@kaod.org>

> Best regards,
> Christian Schoenebeck
> 
>