[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] ui/cocoa: capture all keys and combos when mouse is g
|
From: |
Gustavo Noronha Silva |
|
Subject: |
Re: [PATCH v3 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed |
|
Date: |
Tue, 11 May 2021 14:44:47 -0300 |
|
User-agent: |
Cyrus-JMAP/3.5.0-alpha0-448-gae190416c7-fm-20210505.004-gae190416 |
Hey,
On Tue, May 11, 2021, at 12:08 AM, Akihiko Odaki wrote:
<snip>
> > + CFRunLoopAddSource(runLoop, tapEventsSrc, kCFRunLoopDefaultMode);
> > + CFRelease(tapEventsSrc);
> > +
> > return self;
> > }
> >
>
> These statements should be in "if (self)" block which they follow, or it
> may rely on "self" even if it failed to allocate and initialize "self".
Good catch! How about an early return if init failed instead, though? I'll send
a v4.
Cheers,
Gustavo