Re: [PATCH v1 08/25] gitlab: add build-user-hexagon test

[Alex Bennée]

Alex Bennée <alex.bennee@linaro.org> writes:

> We special case this as the container with the cross compiler for the
> tests takes so long to build it is manually uploaded into the
> registry.

Gahh, something changed underneath me with the inclusion of:

  commit 46ef47e2a77d1a34996964760b4a0d2b19476f25
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   Thu Apr 8 20:07:50 2021 -0500

      Hexagon (target/hexagon) circular addressing

Which leads to the compiler complaining:

  hexagon-unknown-linux-musl-clang  -Wno-incompatible-pointer-types 
-Wno-undefined-internal -fno-unroll-loops -Wall -Werror -O0 -g 
-fno-strict-aliasing -mv67 -O2 -static /home
  /alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c -o circ  -static
  /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:257:1: error: 
unknown register name 'cs0' in asm
  TEST_LOAD_IMM(b,  char,           bbuf, NBYTES, 1, d)
  ^
  /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:242:9: note: 
expanded from macro 'TEST_LOAD_IMM'
          CIRC_LOAD_IMM_##SZ(element, p, BUF, size * sizeof(TYPE), (INC)); \
          ^
  <scratch space>:9:1: note: expanded from here
  CIRC_LOAD_IMM_b
  ^
  /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:75:5: note: expanded 
from macro 'CIRC_LOAD_IMM_b'
      CIRC_LOAD_IMM(b, RES, ADDR, START, LEN, INC)
      ^
  /home/alex.bennee/lsrc/qemu.git/tests/tcg/hexagon/circ.c:73:23: note: 
expanded from macro 'CIRC_LOAD_IMM'
          : "r4", "m0", "cs0")

I suspect the easiest thing to do is to drop the patches again so I
don't hold up the rest of testing/next. I can include the initial docker
image patch but I won't enable it in configure.sh/gitlab.

Would one of the hexagon guys be able to send a new image and verify it
works with the current tests in master?

>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Message-Id: <20210305092328.31792-7-alex.bennee@linaro.org>
> ---
>  .gitlab-ci.yml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 52d65d6c04..87d1172b03 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -413,6 +413,17 @@ build-user-static:
>      CONFIGURE_ARGS: --disable-tools --disable-system --static
>      MAKE_CHECK_ARGS: check-tcg
>  
> +# Because the hexagon cross-compiler takes so long to build we don't rely
> +# on the CI system to build it and hence this job has no dependency
> +# declared. The image is manually uploaded.
> +build-user-hexagon:
> +  <<: *native_build_job_definition
> +  variables:
> +    IMAGE: debian-hexagon-cross
> +    TARGETS: hexagon-linux-user
> +    CONFIGURE_ARGS: --disable-tools --disable-docs --enable-debug-tcg
> +    MAKE_CHECK_ARGS: check-tcg
> +
>  # Only build the softmmu targets we have check-tcg tests for
>  build-some-softmmu:
>    <<: *native_build_job_definition


-- 
Alex Bennée