[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/20] virtio-gpu: Add udmabuf helpers
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH v3 03/20] virtio-gpu: Add udmabuf helpers |
|
Date: |
Tue, 11 May 2021 13:22:16 +0200 |
Hi,
> +void virtio_gpu_fini_udmabuf(struct virtio_gpu_simple_resource *res)
> +{
> + uint32_t size = res->width * res->height * 4;
Hmm, no. We'll go use udmabufs for blob resources only, so this should
not be needed. Maybe squash this with patch #8?
take care,
Gerd
- [PATCH v3 00/20] virtio-gpu: Add support for Blob resources, Vivek Kasireddy, 2021/05/11
- [PATCH v3 06/20] virtio-gpu: Refactor virtio_gpu_create_mapping_iov, Vivek Kasireddy, 2021/05/11
- [PATCH v3 04/20] virtio-gpu: Add virtio_gpu_find_check_resource, Vivek Kasireddy, 2021/05/11
- [PATCH v3 02/20] headers: Add udmabuf.h, Vivek Kasireddy, 2021/05/11
- [PATCH v3 07/20] virtio-gpu: Add initial definitions for blob resources, Vivek Kasireddy, 2021/05/11
- [PATCH v3 03/20] virtio-gpu: Add udmabuf helpers, Vivek Kasireddy, 2021/05/11
- Re: [PATCH v3 03/20] virtio-gpu: Add udmabuf helpers,
Gerd Hoffmann <=
- [PATCH v3 01/20] ui: Get the fd associated with udmabuf driver, Vivek Kasireddy, 2021/05/11
- [PATCH v3 05/20] virtio-gpu: Refactor virtio_gpu_set_scanout, Vivek Kasireddy, 2021/05/11
- [PATCH v3 08/20] virtio-gpu: Add virtio_gpu_resource_create_blob, Vivek Kasireddy, 2021/05/11
- [PATCH v3 10/20] virtio-gpu: Add helpers to create and destroy dmabuf objects, Vivek Kasireddy, 2021/05/11
- [PATCH v3 12/20] virtio-gpu: Add virtio_gpu_set_scanout_blob, Vivek Kasireddy, 2021/05/11
- [PATCH v3 13/20] virtio-gpu: Update cursor data using blob, Vivek Kasireddy, 2021/05/11
- [PATCH v3 11/20] virtio-gpu: Factor out update scanout, Vivek Kasireddy, 2021/05/11
- [PATCH v3 09/20] ui/pixman: Add qemu_pixman_to_drm_format(), Vivek Kasireddy, 2021/05/11