Re: [PATCH] util: fix fd leak in qemu_write_pidfile()

[no-reply]

Patchew URL: 
20210510095708.950474-1-wangjie88@huawei.com/">https://patchew.org/QEMU/20210510095708.950474-1-wangjie88@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210510095708.950474-1-wangjie88@huawei.com
Subject: [PATCH] util: fix fd leak in qemu_write_pidfile()

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210413125533.217440-1-pbonzini@redhat.com -> 
patchew/20210413125533.217440-1-pbonzini@redhat.com
 - [tag update]      
patchew/20210508014802.892561-1-richard.henderson@linaro.org -> 
patchew/20210508014802.892561-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210510095708.950474-1-wangjie88@huawei.com -> 
patchew/20210510095708.950474-1-wangjie88@huawei.com
Auto packing the repository for optimum performance. You may also
run "git gc" manually. See "git help gc" for more information.
Switched to a new branch 'test'
e5d821e util: fix fd leak in qemu_write_pidfile()

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#24: FILE: util/oslib-posix.c:134:
+^Iunlink(path);$

total: 1 errors, 0 warnings, 7 lines checked

Commit e5d821e6eca2 (util: fix fd leak in qemu_write_pidfile()) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210510095708.950474-1-wangjie88@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210510095708.950474-1-wangjie88@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com