Re: [PATCH 1/6] coroutine-sleep: use a stack-allocated timer

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/6] coroutine-sleep: use a stack-allocated timer

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH 1/6] coroutine-sleep: use a stack-allocated timer
Date:	Mon, 10 May 2021 13:00:21 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

03.05.2021 14:25, Paolo Bonzini wrote:

The lifetime of the timer is well-known (it cannot outlive
qemu_co_sleep_ns_wakeable, because it's deleted by the time the
coroutine resumes), so it is not necessary to place it on the heap.

Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/6] coroutine: new sleep/wake API, Paolo Bonzini, 2021/05/03
- [PATCH 1/6] coroutine-sleep: use a stack-allocated timer, Paolo Bonzini, 2021/05/03
  - Re: [PATCH 1/6] coroutine-sleep: use a stack-allocated timer, Vladimir Sementsov-Ogievskiy <=
- [PATCH 2/6] coroutine-sleep: disallow NULL QemuCoSleepState** argument, Paolo Bonzini, 2021/05/03
  - Re: [PATCH 2/6] coroutine-sleep: disallow NULL QemuCoSleepState** argument, Vladimir Sementsov-Ogievskiy, 2021/05/10
- [PATCH 4/6] coroutine-sleep: move timer out of QemuCoSleepState, Paolo Bonzini, 2021/05/03
  - Re: [PATCH 4/6] coroutine-sleep: move timer out of QemuCoSleepState, Vladimir Sementsov-Ogievskiy, 2021/05/10
- [PATCH 3/6] coroutine-sleep: allow qemu_co_sleep_wake that wakes nothing, Paolo Bonzini, 2021/05/03
  - Re: [PATCH 3/6] coroutine-sleep: allow qemu_co_sleep_wake that wakes nothing, Vladimir Sementsov-Ogievskiy, 2021/05/10
- [PATCH 5/6] coroutine-sleep: replace QemuCoSleepState pointer with struct in the API, Paolo Bonzini, 2021/05/03
  - Re: [PATCH 5/6] coroutine-sleep: replace QemuCoSleepState pointer with struct in the API, Vladimir Sementsov-Ogievskiy, 2021/05/10
- [PATCH 6/6] coroutine-sleep: introduce qemu_co_sleep, Paolo Bonzini, 2021/05/03
  - Re: [PATCH 6/6] coroutine-sleep: introduce qemu_co_sleep, Vladimir Sementsov-Ogievskiy, 2021/05/10

Prev by Date: Re: [PATCH v1 01/20] softfloat: Implement float128_(min|minnum|minnummag|max|maxnum|maxnummag)
Next by Date: Re: [PATCH trivial] qapi: spelling fix (addtional)
Previous by thread: [PATCH 1/6] coroutine-sleep: use a stack-allocated timer
Next by thread: [PATCH 2/6] coroutine-sleep: disallow NULL QemuCoSleepState** argument
Index(es):
- Date
- Thread