[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/8] block/write-threshold: drop extra APIs
From: |
Eric Blake |
Subject: |
Re: [PATCH v3 4/8] block/write-threshold: drop extra APIs |
Date: |
Fri, 7 May 2021 09:18:13 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
On 5/6/21 4:06 AM, Vladimir Sementsov-Ogievskiy wrote:
> bdrv_write_threshold_exceeded() is unused at all.
either:
s/unused/not used/
or:
s/ at all//
>
> bdrv_write_threshold_is_set() is used only to double check the value of
> bs->write_threshold_offset in tests. No real sense in it (both tests do
> check real value with help of bdrv_write_threshold_get())
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v3 0/8] block: refactor write threshold, Vladimir Sementsov-Ogievskiy, 2021/05/06
- [PATCH v3 2/8] block: drop write notifiers, Vladimir Sementsov-Ogievskiy, 2021/05/06
- [PATCH v3 5/8] block/write-threshold: don't use aio context lock, Vladimir Sementsov-Ogievskiy, 2021/05/06
- [PATCH v3 1/8] block/write-threshold: don't use write notifiers, Vladimir Sementsov-Ogievskiy, 2021/05/06
- [PATCH v3 3/8] test-write-threshold: rewrite test_threshold_(not_)trigger tests, Vladimir Sementsov-Ogievskiy, 2021/05/06
- [PATCH v3 8/8] write-threshold: deal with includes, Vladimir Sementsov-Ogievskiy, 2021/05/06
- [PATCH v3 4/8] block/write-threshold: drop extra APIs, Vladimir Sementsov-Ogievskiy, 2021/05/06
- Re: [PATCH v3 4/8] block/write-threshold: drop extra APIs,
Eric Blake <=
- [PATCH v3 6/8] test-write-threshold: drop extra tests, Vladimir Sementsov-Ogievskiy, 2021/05/06
- [PATCH v3 7/8] test-write-threshold: drop extra TestStruct structure, Vladimir Sementsov-Ogievskiy, 2021/05/06
- Re: [PATCH v3 0/8] block: refactor write threshold, Stefan Hajnoczi, 2021/05/12
- Re: [PATCH v3 0/8] block: refactor write threshold, Max Reitz, 2021/05/12