[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 06/10] KVM: Simplify dirty log sync in kvm_set_phys_mem
From: |
Peter Xu |
Subject: |
[PATCH v7 06/10] KVM: Simplify dirty log sync in kvm_set_phys_mem |
Date: |
Thu, 6 May 2021 12:05:45 -0400 |
kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because
the section can be a superset of the memslot that we're working on. The result
is that if the section covers multiple kvm memslots, we could be doing the
synchronization for multiple times for each kvmslot in the section.
With the two helpers that we just introduced, it's very easy to do it right now
by calling the helpers.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
accel/kvm/kvm-all.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 1025701f557..4b786240a04 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -1161,7 +1161,8 @@ static void kvm_set_phys_mem(KVMMemoryListener *kml,
goto out;
}
if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
- kvm_physical_sync_dirty_bitmap(kml, section);
+ kvm_slot_get_dirty_log(kvm_state, mem);
+ kvm_slot_sync_dirty_pages(mem);
}
/* unregister the slot */
--
2.31.1
- [PATCH v7 00/10] KVM: Dirty ring support (QEMU part), Peter Xu, 2021/05/06
- [PATCH v7 01/10] memory: Introduce log_sync_global() to memory listener, Peter Xu, 2021/05/06
- [PATCH v7 02/10] KVM: Use a big lock to replace per-kml slots_lock, Peter Xu, 2021/05/06
- [PATCH v7 04/10] KVM: Provide helper to get kvm dirty log, Peter Xu, 2021/05/06
- [PATCH v7 05/10] KVM: Provide helper to sync dirty bitmap from slot to ramblock, Peter Xu, 2021/05/06
- [PATCH v7 03/10] KVM: Create the KVMSlot dirty bitmap on flag changes, Peter Xu, 2021/05/06
- [PATCH v7 06/10] KVM: Simplify dirty log sync in kvm_set_phys_mem,
Peter Xu <=
- [PATCH v7 08/10] KVM: Add dirty-gfn-count property, Peter Xu, 2021/05/06
- [PATCH v7 07/10] KVM: Cache kvm slot dirty bitmap size, Peter Xu, 2021/05/06
- [PATCH v7 09/10] KVM: Disable manual dirty log when dirty ring enabled, Peter Xu, 2021/05/06
- [PATCH v7 10/10] KVM: Dirty ring support, Peter Xu, 2021/05/06
- Re: [PATCH v7 00/10] KVM: Dirty ring support (QEMU part), Paolo Bonzini, 2021/05/14