[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 24/26] vhost-user-fs: Extend VhostUserFSSlaveMsg to pass a
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH v3 24/26] vhost-user-fs: Extend VhostUserFSSlaveMsg to pass additional info |
|
Date: |
Thu, 6 May 2021 16:32:46 +0100 |
On Wed, Apr 28, 2021 at 12:00:58PM +0100, Dr. David Alan Gilbert (git) wrote:
> @@ -144,6 +148,8 @@ typedef struct {
> } VhostUserFSSlaveMsgEntry;
>
> typedef struct {
> + /* Generic flags for the overall message */
> + uint32_t flags;
> /* Number of entries */
> uint16_t count;
> /* Spare */
Please introduce the uint32_t field as a reserved field in the earlier
patch that left a hole in the struct. Everything is okay once we get to
this patch but the earlier patches should have avoided the hole too
(they had the confusing uint16_t padding field which was not enough to
avoid the 64-bit alignment hole).
signature.asc
Description: PGP signature