Re: [PATCH v21 09/20] multi-process: define MPQemuMsg format and transmission functions

[Jag Raman]

> On May 6, 2021, at 10:27 AM, Thomas Huth <thuth@redhat.com> wrote:
> 
> On 29/01/2021 17.46, Jagannathan Raman wrote:
>> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> Defines MPQemuMsg, which is the message that is sent to the remote
>> process. This message is sent over QIOChannel and is used to
>> command the remote process to perform various tasks.
>> Define transmission functions used by proxy and by remote.
>> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
>> Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
>> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
> [...]
>> diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c
>> new file mode 100644
>> index 0000000..b3d380e
>> --- /dev/null
>> +++ b/hw/remote/mpqemu-link.c
> [...]
>> +bool mpqemu_msg_valid(MPQemuMsg *msg)
>> +{
>> +    if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
>> +        return false;
>> +    }
> 
> Hi!
> 
> A bug in this code has been reported on Launchpad:
> 
> https://bugs.launchpad.net/qemu/+bug/1926995
> 
> Could someone please send a patch for this issue?

Thank you for sharing it, Thomas!

Will jump on it right away.

--
Jag

> 
> Thanks,
>  Thomas
>