Re: [RESEND PATCH 29/32] qmp: Add the qmp_query_sgx_capabilities()

[Yang Zhong]

On Mon, May 03, 2021 at 01:00:37PM -0500, Eric Blake wrote:
> On 4/30/21 1:24 AM, Yang Zhong wrote:
> > The libvirt can use qmp_query_sgx_capabilities() to get the host
> 
> s/The libvirt/Libvirt/
> 
> > sgx capabilitis.
> > 
> 
> capabilities
> 
  Eric, thanks for your comments! I will change those mistakes, thanks!

  Yang
  
> > Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> > ---
> >  hw/i386/sgx-epc.c          | 66 ++++++++++++++++++++++++++++++++++++++
> >  include/hw/i386/pc.h       |  1 +
> >  monitor/qmp-cmds.c         |  5 +++
> >  qapi/misc.json             | 19 +++++++++++
> >  stubs/sgx-stub.c           |  5 +++
> >  tests/qtest/qmp-cmd-test.c |  1 +
> >  6 files changed, 97 insertions(+)
> > 
> 
> > +++ b/qapi/misc.json
> > @@ -561,3 +561,22 @@
> >  #
> >  ##
> >  { 'command': 'query-sgx', 'returns': 'SGXInfo' }
> > +
> > +
> > +##
> > +# @query-sgx-capabilities:
> > +#
> > +# Returns information from host SGX capabilities
> > +#
> > +# Returns: @SGXInfo
> > +#
> > +# Since: 5.1
> 
> 6.1
> 

  Ditto, thanks!

  Yang


> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "query-sgx-capabilities" }
> > +# <- { "return": { "sgx": true, "sgx1" : true, "sgx2" : true,
> > +#                  "flc": true, "section-size" : 0 } }
> > +#
> > +##
> > +{ 'command': 'query-sgx-capabilities', 'returns': 'SGXInfo' }
> > diff --git a/stubs/sgx-stub.c b/stubs/sgx-stub.c
> > index c2b59a88fd..1dedf3f3db 100644
> > --- a/stubs/sgx-stub.c
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org