Re: [PATCH v6 10/12] qtest/bios-tables-test: Rename TCG specific tests

[Igor Mammedov]

On Mon,  3 May 2021 23:10:18 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> Some tests require TCG, but don't have '_tcg' in their name,
> while others do. Unify the test names by adding 'tcg' to the
> TCG specific tests.
> 
> Reported-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/bios-tables-test.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index ce498b3ff48..ad877baeb1b 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1255,7 +1255,7 @@ static void test_acpi_microvm_rtc(void)
>      free_test_data(&data);
>  }
>  
> -static void test_acpi_microvm_pcie(void)
> +static void test_acpi_microvm_pcie_tcg(void)
>  {
>      test_data data;
>  
> @@ -1475,7 +1475,7 @@ static void test_acpi_oem_fields_microvm(void)
>      g_free(args);
>  }
>  
> -static void test_acpi_oem_fields_virt(void)
> +static void test_acpi_oem_fields_virt_tcg(void)
>  {
>      test_data data = {
>          .machine = "virt",
> @@ -1555,14 +1555,14 @@ int main(int argc, char *argv[])
>          qtest_add_func("acpi/microvm/ioapic2", test_acpi_microvm_ioapic2);
>          qtest_add_func("acpi/microvm/oem-fields", 
> test_acpi_oem_fields_microvm);
>          if (strcmp(arch, "x86_64") == 0) {
> -            qtest_add_func("acpi/microvm/pcie", test_acpi_microvm_pcie);
> +            qtest_add_func("acpi/microvm/pcie", test_acpi_microvm_pcie_tcg);
>          }
>      } else if (strcmp(arch, "aarch64") == 0) {
>          qtest_add_func("acpi/virt", test_acpi_virt_tcg);
>          qtest_add_func("acpi/virt/numamem", test_acpi_virt_tcg_numamem);
>          qtest_add_func("acpi/virt/memhp", test_acpi_virt_tcg_memhp);
>          qtest_add_func("acpi/virt/pxb", test_acpi_virt_tcg_pxb);
> -        qtest_add_func("acpi/virt/oem-fields", test_acpi_oem_fields_virt);
> +        qtest_add_func("acpi/virt/oem-fields", 
> test_acpi_oem_fields_virt_tcg);
>      }
>      ret = g_test_run();
>      boot_sector_cleanup(disk);