Re: [PATCH v5 00/11] 64bit block-layer: part II

[Vladimir Sementsov-Ogievskiy]

05.05.2021 11:06, no-reply@patchew.org wrote:
> Patchew URL: 
> 20210505075001.45041-1-vsementsov@virtuozzo.com/">https://patchew.org/QEMU/20210505075001.45041-1-vsementsov@virtuozzo.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 20210505075001.45041-1-vsementsov@virtuozzo.com
> Subject: [PATCH v5 00/11] 64bit block-layer: part II
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>  From https://github.com/patchew-project/qemu
>   - [tag update]      patchew/20210505045824.33880-1-liq3ea@163.com -> 
> patchew/20210505045824.33880-1-liq3ea@163.com
>   * [new tag]         patchew/20210505075001.45041-1-vsementsov@virtuozzo.com 
> -> patchew/20210505075001.45041-1-vsementsov@virtuozzo.com
> Switched to a new branch 'test'
> 3700aaf block/io: allow 64bit discard requests
> 54ba548 block: use int64_t instead of int in driver discard handlers
> 7a3aaa5 block: make BlockLimits::max_pdiscard 64bit
> f80faf7 block/io: allow 64bit write-zeroes requests
> 4cc3310 block: use int64_t instead of int in driver write_zeroes handlers
> 136dd63 block: make BlockLimits::max_pwrite_zeroes 64bit
> 03a7c45 block: use int64_t instead of uint64_t in copy_range driver handlers
> 496fe8b block: use int64_t instead of uint64_t in driver write handlers
> eefb31d block: use int64_t instead of uint64_t in driver read handlers
> fb7a119 qcow2: check request on vmstate save/load path
> 23ba0f4 block/io: bring request check to bdrv_co_(read, write)v_vmstate
>
> === OUTPUT BEGIN ===
> 1/11 Checking commit 23ba0f4a09c1 (block/io: bring request check to 
> bdrv_co_(read, write)v_vmstate)
> ERROR: Author email address is mangled by the mailing list
> #2:
> Author: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>
>
> total: 1 errors, 0 warnings, 42 lines checked
>
> Patch 1/11 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

So, s/{}/()/ doesn't help.

> 2/11 Checking commit fb7a119cd9aa (qcow2: check request on vmstate save/load 
> path)
> 3/11 Checking commit eefb31d480b4 (block: use int64_t instead of uint64_t in 
> driver read handlers)
> 4/11 Checking commit 496fe8b2e7ce (block: use int64_t instead of uint64_t in 
> driver write handlers)
> 5/11 Checking commit 03a7c4534a58 (block: use int64_t instead of uint64_t in 
> copy_range driver handlers)
> 6/11 Checking commit 136dd63cc723 (block: make BlockLimits::max_pwrite_zeroes 
> 64bit)
> 7/11 Checking commit 4cc3310d243e (block: use int64_t instead of int in driver 
> write_zeroes handlers)
> 8/11 Checking commit f80faf73a84a (block/io: allow 64bit write-zeroes requests)
> 9/11 Checking commit 7a3aaa587314 (block: make BlockLimits::max_pdiscard 64bit)
> 10/11 Checking commit 54ba54860b4a (block: use int64_t instead of int in driver 
> discard handlers)
> 11/11 Checking commit 3700aafec1ff (block/io: allow 64bit discard requests)
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> The full log is available at
> 20210505075001.45041-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210505075001.45041-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com


--
Best regards,
Vladimir