[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/7] vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset'
From: |
Li Qiang |
Subject: |
[PATCH 7/7] vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset' |
Date: |
Tue, 4 May 2021 21:58:24 -0700 |
If 'virgl_cmd_get_capset' set 'max_size' to 0,
the 'virgl_renderer_fill_caps' will write the data after the 'resp'.
This patch avoid this by checking the returned 'max_size'.
Signed-off-by: Li Qiang <liq3ea@163.com>
---
contrib/vhost-user-gpu/virgl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
index a16a311d80..7172104b19 100644
--- a/contrib/vhost-user-gpu/virgl.c
+++ b/contrib/vhost-user-gpu/virgl.c
@@ -177,6 +177,10 @@ virgl_cmd_get_capset(VuGpu *g,
virgl_renderer_get_cap_set(gc.capset_id, &max_ver,
&max_size);
+ if (!max_size) {
+ cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER;
+ return;
+ }
resp = g_malloc0(sizeof(*resp) + max_size);
resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET;
--
2.25.1
[PATCH 7/7] vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset',
Li Qiang <=
[PATCH 5/7] vhost-user-gpu: fix memory leak in 'virgl_cmd_resource_unref', Li Qiang, 2021/05/05
[PATCH 3/7] vhost-user-gpu: fix memory leak in vg_resource_attach_backing, Li Qiang, 2021/05/05
[PATCH 6/7] vhost-user-gpu: fix memory leak in 'virgl_resource_attach_backing', Li Qiang, 2021/05/05