qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 07/27] virtio-snd: Add properties for class init


From: Shreyansh Chouhan
Subject: Re: [RFC PATCH 07/27] virtio-snd: Add properties for class init
Date: Wed, 5 May 2021 01:05:35 +0530

On Tue, 4 May 2021 at 19:02, Laurent Vivier <laurent@vivier.eu> wrote:
There is nothing specific to PCI in that code, why do you prevent the use of virtio-snd as a MMIO
device?

I am sorry I do not understand your question completely. If by preventing the use of virtio-snd, you mean
why did I add the PCI dependencies to the Kconfig file, then I think I must have been a bit confused
while writing it. VIRTIO_PCI already includes those dependencies, I will change the dependency to
VIRTIO. (Which is what it is for other virtio devices too.)

However if you mean why did I not add an MMIO binding for this device, then there is no
specific reason. I simply followed what QEMU had been doing for the other virtio devices.
Will there be any advantages to implementing the device as a MMIO device? 
Thanks,

Laurent

-- 
Regards
Shreyansh 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]