Re: [PATCH v2 00/30] testing/next (hexagon, tricore, ppc, signals, cirr

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/30] testing/next (hexagon, tricore, ppc, signals, cirr

From:	no-reply
Subject:	Re: [PATCH v2 00/30] testing/next (hexagon, tricore, ppc, signals, cirrus)
Date:	Tue, 4 May 2021 03:39:52 -0700 (PDT)
Patchew URL: 
20210504100223.25427-1-alex.bennee@linaro.org/">https://patchew.org/QEMU/20210504100223.25427-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210504100223.25427-1-alex.bennee@linaro.org
Subject: [PATCH  v2 00/30] testing/next (hexagon, tricore, ppc, signals, cirrus)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210504100223.25427-1-alex.bennee@linaro.org -> 
patchew/20210504100223.25427-1-alex.bennee@linaro.org
 - [tag update]      patchew/20210504100545.112213-1-dgilbert@redhat.com -> 
patchew/20210504100545.112213-1-dgilbert@redhat.com
Switched to a new branch 'test'
c91b027 configure: use cc, not host_cc to set cross_cc for build arch
68da1a5 cirrus.yml: Fix the MSYS2 task
dbc4eac tests/tcg: add a multiarch signals test to stress test signal delivery
775ac55 tests/tcg/ppc64le: tests for brh/brw/brd
bf6793b tests/docker: gcc-10 based images for ppc64{, le} tests
279b264 tests/tcg/tricore: Add muls test
a730630 tests/tcg/tricore: Add msub test
6abe70e tests/tcg/tricore: Add madd test
03bcac9 tests/tcg/tricore: Add ftoi test
0bcb010 tests/tcg/tricore: Add fmul test
b41e172 tests/tcg/tricore: Add fadd test
15c3104 tests/tcg/tricore: Add dvstep test
060e17c tests/tcg/tricore: Add clz test
3cafa12 tests/tcg/tricore: Add bmerge test
4f6f9c2 tests/tcg/tricore: Add macros to create tests and first test 'abs'
f4d9deb configure: Emit HOST_CC to config-host.mak
38cf8f0 tests/tcg/tricore: Add build infrastructure
0edbd12 hw/tricore: Add testdevice for tests in tests/tcg/
eb3c5b5 tests/tcg: Run timeout cmds using --foreground
583bc64 tests/tcg: Add docker_as and docker_ld cmds
98212d6 tests/docker: Added libbpf library to the docker files.
12d91c4 tests/tcg: don't iterate through other arch compilers
37f804f gitlab: add build-user-hexagon test
f18332c tests/tcg: Use Hexagon Docker image
dcf3ddc docker: Add Hexagon image
40cb310 tests/docker: add "fetch" sub-command
8798129 tests/docker: allow "update" to add the current user
52459e7 tests/docker: make executable an optional argument to "update"
2379848 tests/docker: fix copying of executable in "update"
51cafd2 checkpatch: Fix use of uninitialized value

=== OUTPUT BEGIN ===
1/30 Checking commit 51cafd2e3c4d (checkpatch: Fix use of uninitialized value)
2/30 Checking commit 23798480f6b7 (tests/docker: fix copying of executable in 
"update")
3/30 Checking commit 52459e70e0cf (tests/docker: make executable an optional 
argument to "update")
4/30 Checking commit 879812962b47 (tests/docker: allow "update" to add the 
current user)
5/30 Checking commit 40cb310803ff (tests/docker: add "fetch" sub-command)
6/30 Checking commit dcf3ddc604fd (docker: Add Hexagon image)
WARNING: line over 80 characters
#205: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:63:
+    -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic 
--target=hexagon-unknown-linux-musl " \

ERROR: line over 90 characters
#232: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:90:
+    CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

ERROR: line over 90 characters
#269: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh:127:
+    CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

total: 2 errors, 1 warnings, 221 lines checked

Patch 6/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/30 Checking commit f18332c48a35 (tests/tcg: Use Hexagon Docker image)
8/30 Checking commit 37f804f44baa (gitlab: add build-user-hexagon test)
9/30 Checking commit 12d91c450e8b (tests/tcg: don't iterate through other arch 
compilers)
10/30 Checking commit 98212d6201f2 (tests/docker: Added libbpf library to the 
docker files.)
11/30 Checking commit 583bc6479039 (tests/tcg: Add docker_as and docker_ld cmds)
12/30 Checking commit eb3c5b5266ad (tests/tcg: Run timeout cmds using 
--foreground)
13/30 Checking commit 0edbd12f6075 (hw/tricore: Add testdevice for tests in 
tests/tcg/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
new file mode 100644

total: 0 errors, 1 warnings, 152 lines checked

Patch 13/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/30 Checking commit 38cf8f0eb3ad (tests/tcg/tricore: Add build infrastructure)
15/30 Checking commit f4d9debabfc6 (configure: Emit HOST_CC to config-host.mak)
16/30 Checking commit 4f6f9c2d6074 (tests/tcg/tricore: Add macros to create 
tests and first test 'abs')
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#67: FILE: tests/tcg/tricore/macros.h:2:
+#define LI(reg, val)           \
+    mov.u reg, lo:val;         \
+    movh DREG_TEMP_LI, up:val; \
+    or reg, reg, DREG_TEMP_LI; \
+

ERROR: spaces required around that ':' (ctx:VxV)
#68: FILE: tests/tcg/tricore/macros.h:3:
+    mov.u reg, lo:val;         \
                  ^

ERROR: spaces required around that ':' (ctx:VxV)
#69: FILE: tests/tcg/tricore/macros.h:4:
+    movh DREG_TEMP_LI, up:val; \
                          ^

ERROR: spaces required around that '%' (ctx:WxV)
#75: FILE: tests/tcg/tricore/macros.h:10:
+#define DREG_RS1 %d0
                  ^

ERROR: Macros with complex values should be enclosed in parenthesis
#75: FILE: tests/tcg/tricore/macros.h:10:
+#define DREG_RS1 %d0

ERROR: spaces required around that '%' (ctx:WxV)
#76: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_CALC_RESULT %d1
                          ^

ERROR: Macros with complex values should be enclosed in parenthesis
#76: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_CALC_RESULT %d1

ERROR: spaces required around that '%' (ctx:WxV)
#77: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_TEMP_LI %d10
                      ^

ERROR: Macros with complex values should be enclosed in parenthesis
#77: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_TEMP_LI %d10

ERROR: spaces required around that '%' (ctx:WxV)
#78: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_TEMP %d11
                   ^

ERROR: Macros with complex values should be enclosed in parenthesis
#78: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_TEMP %d11

ERROR: spaces required around that '%' (ctx:WxV)
#79: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_TEST_NUM %d14
                       ^

ERROR: Macros with complex values should be enclosed in parenthesis
#79: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_TEST_NUM %d14

ERROR: spaces required around that '%' (ctx:WxV)
#80: FILE: tests/tcg/tricore/macros.h:15:
+#define DREG_CORRECT_RESULT %d15
                             ^

ERROR: Macros with complex values should be enclosed in parenthesis
#80: FILE: tests/tcg/tricore/macros.h:15:
+#define DREG_CORRECT_RESULT %d15

ERROR: spaces required around that '%' (ctx:WxV)
#82: FILE: tests/tcg/tricore/macros.h:17:
+#define DREG_DEV_ADDR %a15
                       ^

ERROR: Macros with complex values should be enclosed in parenthesis
#82: FILE: tests/tcg/tricore/macros.h:17:
+#define DREG_DEV_ADDR %a15

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#85: FILE: tests/tcg/tricore/macros.h:20:
+#define TEST_CASE(num, testreg, correct, code...) \
+test_ ## num:                                     \
+    code;                                         \
+    LI(DREG_CORRECT_RESULT, correct)              \
+    mov DREG_TEST_NUM, num;                       \
+    jne testreg, DREG_CORRECT_RESULT, fail        \
+

ERROR: spaces required around that ':' (ctx:VxE)
#86: FILE: tests/tcg/tricore/macros.h:21:
+test_ ## num:                                     \
             ^

WARNING: Block comments use a leading /* on a separate line
#92: FILE: tests/tcg/tricore/macros.h:27:
+/* Actual test case type

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#104: FILE: tests/tcg/tricore/macros.h:39:
+#define TEST_PASSFAIL                       \
+        j pass;                             \
+fail:                                       \
+        LI(DREG_TEMP, TESTDEV_ADDR)         \
+        mov.a DREG_DEV_ADDR, DREG_TEMP;     \
+        st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+        debug;                              \
+        j fail;                             \
+pass:                                       \
+        LI(DREG_TEMP, TESTDEV_ADDR)         \
+        mov.a DREG_DEV_ADDR, DREG_TEMP;     \
+        mov DREG_TEST_NUM, 0;               \
+        st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\
+        debug;                              \
+        j pass;

ERROR: space prohibited before open square bracket '['
#109: FILE: tests/tcg/tricore/macros.h:44:
+        st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\

ERROR: space prohibited before open square bracket '['
#116: FILE: tests/tcg/tricore/macros.h:51:
+        st.w [DREG_DEV_ADDR], DREG_TEST_NUM;\

total: 22 errors, 2 warnings, 80 lines checked

Patch 16/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/30 Checking commit 3cafa12879ab (tests/tcg/tricore: Add bmerge test)
ERROR: spaces required around that '%' (ctx:WxV)
#38: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_RS2 %d1
                  ^

ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: tests/tcg/tricore/macros.h:11:
+#define DREG_RS2 %d1

ERROR: spaces required around that '%' (ctx:WxV)
#40: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_CALC_PSW %d2
                       ^

ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: tests/tcg/tricore/macros.h:13:
+#define DREG_CALC_PSW %d2

ERROR: spaces required around that '%' (ctx:WxV)
#41: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_CORRECT_PSW %d3
                          ^

ERROR: Macros with complex values should be enclosed in parenthesis
#41: FILE: tests/tcg/tricore/macros.h:14:
+#define DREG_CORRECT_PSW %d3

ERROR: spaces required around that ':' (ctx:VxE)
#50: FILE: tests/tcg/tricore/macros.h:31:
+test_ ## num:                                                      \
             ^

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#81: 
new file mode 100644

total: 7 errors, 1 warnings, 58 lines checked

Patch 17/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/30 Checking commit 060e17c4615e (tests/tcg/tricore: Add clz test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 16 lines checked

Patch 18/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/30 Checking commit 15c3104d8529 (tests/tcg/tricore: Add dvstep test)
ERROR: spaces required around that '%' (ctx:WxV)
#38: FILE: tests/tcg/tricore/macros.h:22:
+#define EREG_RS1 %e6
                  ^

ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: tests/tcg/tricore/macros.h:22:
+#define EREG_RS1 %e6

ERROR: spaces required around that '%' (ctx:WxV)
#39: FILE: tests/tcg/tricore/macros.h:23:
+#define EREG_RS1_LO %d6
                     ^

ERROR: Macros with complex values should be enclosed in parenthesis
#39: FILE: tests/tcg/tricore/macros.h:23:
+#define EREG_RS1_LO %d6

ERROR: spaces required around that '%' (ctx:WxV)
#40: FILE: tests/tcg/tricore/macros.h:24:
+#define EREG_RS1_HI %d7
                     ^

ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: tests/tcg/tricore/macros.h:24:
+#define EREG_RS1_HI %d7

ERROR: spaces required around that '%' (ctx:WxV)
#41: FILE: tests/tcg/tricore/macros.h:25:
+#define EREG_RS2 %e8
                  ^

ERROR: Macros with complex values should be enclosed in parenthesis
#41: FILE: tests/tcg/tricore/macros.h:25:
+#define EREG_RS2 %e8

ERROR: spaces required around that '%' (ctx:WxV)
#42: FILE: tests/tcg/tricore/macros.h:26:
+#define EREG_RS2_LO %d8
                     ^

ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: tests/tcg/tricore/macros.h:26:
+#define EREG_RS2_LO %d8

ERROR: spaces required around that '%' (ctx:WxV)
#43: FILE: tests/tcg/tricore/macros.h:27:
+#define EREG_RS2_HI %d9
                     ^

ERROR: Macros with complex values should be enclosed in parenthesis
#43: FILE: tests/tcg/tricore/macros.h:27:
+#define EREG_RS2_HI %d9

ERROR: spaces required around that '%' (ctx:WxV)
#44: FILE: tests/tcg/tricore/macros.h:28:
+#define EREG_CALC_RESULT %e8
                          ^

ERROR: Macros with complex values should be enclosed in parenthesis
#44: FILE: tests/tcg/tricore/macros.h:28:
+#define EREG_CALC_RESULT %e8

ERROR: spaces required around that '%' (ctx:WxV)
#45: FILE: tests/tcg/tricore/macros.h:29:
+#define EREG_CALC_RESULT_HI %d9
                             ^

ERROR: Macros with complex values should be enclosed in parenthesis
#45: FILE: tests/tcg/tricore/macros.h:29:
+#define EREG_CALC_RESULT_HI %d9

ERROR: spaces required around that '%' (ctx:WxV)
#46: FILE: tests/tcg/tricore/macros.h:30:
+#define EREG_CALC_RESULT_LO %d8
                             ^

ERROR: Macros with complex values should be enclosed in parenthesis
#46: FILE: tests/tcg/tricore/macros.h:30:
+#define EREG_CALC_RESULT_LO %d8

ERROR: spaces required around that '%' (ctx:WxV)
#47: FILE: tests/tcg/tricore/macros.h:31:
+#define EREG_CORRECT_RESULT_LO %d0
                                ^

ERROR: Macros with complex values should be enclosed in parenthesis
#47: FILE: tests/tcg/tricore/macros.h:31:
+#define EREG_CORRECT_RESULT_LO %d0

ERROR: spaces required around that '%' (ctx:WxV)
#48: FILE: tests/tcg/tricore/macros.h:32:
+#define EREG_CORRECT_RESULT_HI %d1
                                ^

ERROR: Macros with complex values should be enclosed in parenthesis
#48: FILE: tests/tcg/tricore/macros.h:32:
+#define EREG_CORRECT_RESULT_HI %d1

ERROR: spaces required around that ':' (ctx:VxE)
#58: FILE: tests/tcg/tricore/macros.h:43:
+test_ ## num:                                              \
             ^

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
new file mode 100644

total: 23 errors, 1 warnings, 69 lines checked

Patch 19/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/30 Checking commit b41e172b1c1b (tests/tcg/tricore: Add fadd test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 23 lines checked

Patch 20/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/30 Checking commit 0bcb010ab78c (tests/tcg/tricore: Add fmul test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 15 lines checked

Patch 21/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/30 Checking commit 03bcac9b31c0 (tests/tcg/tricore: Add ftoi test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 30 lines checked

Patch 22/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/30 Checking commit 6abe70e64dae (tests/tcg/tricore: Add madd test)
ERROR: spaces required around that '%' (ctx:WxV)
#38: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_RS3 %d4
                  ^

ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: tests/tcg/tricore/macros.h:12:
+#define DREG_RS3 %d4

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#67: 
new file mode 100644

total: 2 errors, 1 warnings, 48 lines checked

Patch 23/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/30 Checking commit a730630561a3 (tests/tcg/tricore: Add msub test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 16 lines checked

Patch 24/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/30 Checking commit 279b264665ef (tests/tcg/tricore: Add muls test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 16 lines checked

Patch 25/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/30 Checking commit bf6793bcf60c (tests/docker: gcc-10 based images for 
ppc64{, le} tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#83: 
deleted file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 26/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/30 Checking commit 775ac5548c46 (tests/tcg/ppc64le: tests for brh/brw/brd)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
new file mode 100644

total: 0 errors, 1 warnings, 55 lines checked

Patch 27/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/30 Checking commit dbc4eac4eab3 (tests/tcg: add a multiarch signals test to 
stress test signal delivery)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 181 lines checked

Patch 28/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/30 Checking commit 68da1a516aaf (cirrus.yml: Fix the MSYS2 task)
30/30 Checking commit c91b027fedcc (configure: use cc, not host_cc to set 
cross_cc for build arch)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210504100223.25427-1-alex.bennee@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210504100223.25427-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
[Prev in Thread]
Current Thread
[Next in Thread]
[PATCH v2 27/30] tests/tcg/ppc64le: tests for brh/brw/brd, (continued)
- [PATCH v2 27/30] tests/tcg/ppc64le: tests for brh/brw/brd, Alex Bennée, 2021/05/04
- [PATCH v2 23/30] tests/tcg/tricore: Add madd test, Alex Bennée, 2021/05/04
- [PATCH v2 20/30] tests/tcg/tricore: Add fadd test, Alex Bennée, 2021/05/04
- [PATCH v2 18/30] tests/tcg/tricore: Add clz test, Alex Bennée, 2021/05/04
- [PATCH v2 26/30] tests/docker: gcc-10 based images for ppc64{, le} tests, Alex Bennée, 2021/05/04
- [PATCH v2 25/30] tests/tcg/tricore: Add muls test, Alex Bennée, 2021/05/04
- [PATCH v2 12/30] tests/tcg: Run timeout cmds using --foreground, Alex Bennée, 2021/05/04
- [PATCH v2 22/30] tests/tcg/tricore: Add ftoi test, Alex Bennée, 2021/05/04
- [PATCH v2 24/30] tests/tcg/tricore: Add msub test, Alex Bennée, 2021/05/04
- [PATCH v2 15/30] configure: Emit HOST_CC to config-host.mak, Alex Bennée, 2021/05/04
- Re: [PATCH v2 00/30] testing/next (hexagon, tricore, ppc, signals, cirrus), no-reply <=
Prev by Date: Re: [PATCH-for-6.0?] hw/arm/imx25_pdk: Fix error message for invalid RAM size
Next by Date: Re: [PATCH for-6.0? 0/6] extern "C" overhaul for C++ files
Previous by thread: [PATCH v2 15/30] configure: Emit HOST_CC to config-host.mak
Next by thread: [PATCH] tests/migration-test: Fix "true" vs true
Index(es):
- Date
- Thread