[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] block: bdrv_reopen_multiple(): fix leak of tran object
|
From: |
Alberto Garcia |
|
Subject: |
Re: [PATCH 2/6] block: bdrv_reopen_multiple(): fix leak of tran object |
|
Date: |
Mon, 03 May 2021 17:52:44 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 03 May 2021 01:33:58 PM CEST, Vladimir Sementsov-Ogievskiy
<vsementsov@virtuozzo.com> wrote:
> We have one path, where tran object is created, but we don't touch and
> don't free it in any way: "goto cleanup" in first loop with calls to
> bdrv_flush().
>
> Fix it simply moving tran_new() call below that loop.
>
> Reported-by: Coverity (CID 1452772)
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Fixes: 72373e40fbc7e4218061a8211384db362d3e7348
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
- [PATCH 0/6] block permission updated follow-up, Vladimir Sementsov-Ogievskiy, 2021/05/03
- [PATCH 1/6] block: fix leak of tran in bdrv_root_attach_child, Vladimir Sementsov-Ogievskiy, 2021/05/03
- [PATCH 2/6] block: bdrv_reopen_multiple(): fix leak of tran object, Vladimir Sementsov-Ogievskiy, 2021/05/03
- Re: [PATCH 2/6] block: bdrv_reopen_multiple(): fix leak of tran object,
Alberto Garcia <=
- [PATCH 6/6] block: improve permission conflict error message, Vladimir Sementsov-Ogievskiy, 2021/05/03
- [PATCH 3/6] block-backend: improve blk_root_get_parent_desc(), Vladimir Sementsov-Ogievskiy, 2021/05/03
- [PATCH 4/6] block: improve bdrv_child_get_parent_desc(), Vladimir Sementsov-Ogievskiy, 2021/05/03
- [PATCH 5/6] block: simplify bdrv_child_user_desc(), Vladimir Sementsov-Ogievskiy, 2021/05/03
- [PATCH 7/6] block: document child argument of bdrv_attach_child_common(), Vladimir Sementsov-Ogievskiy, 2021/05/03