[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527) |
Date: |
Mon, 3 May 2021 11:57:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/3/21 11:27 AM, Philippe Mathieu-Daudé wrote:
> On 5/3/21 11:14 AM, Gerd Hoffmann wrote:
>> Use autofree heap allocation instead.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Fixes: 4f4321c11ff ("usb: use iovecs in USBPacket")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Hmm there is still another use:
618 if (dev->endpoint[EP2I(ep)].iso_started) {
619 struct usb_redir_iso_packet_header iso_packet = {
620 .endpoint = ep,
621 .length = p->iov.size
622 };
623 uint8_t buf[p->iov.size];
- [PATCH 0/5] usb: fix some memory allocation issues., Gerd Hoffmann, 2021/05/03
- [PATCH 3/5] usb/mtp: avoid dynamic stack allocation, Gerd Hoffmann, 2021/05/03
- [PATCH 1/5] usb/hid: avoid dynamic stack allocation, Gerd Hoffmann, 2021/05/03
- [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527), Gerd Hoffmann, 2021/05/03
- [PATCH 5/5] usb: limit combined packets to 1 MiB, Gerd Hoffmann, 2021/05/03
- [PATCH 4/5] usb/xhci: sanity check packet size, Gerd Hoffmann, 2021/05/03
- Re: [PATCH 0/5] usb: fix some memory allocation issues., Philippe Mathieu-Daudé, 2021/05/03