Re: [PATCH] block/rbd: Add support for rbd image encryption

[no-reply]

Patchew URL: 20210502073617.2978836-1-oro@il.ibm.com/">https://patchew.org/QEMU/20210502073617.2978836-1-oro@il.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210502073617.2978836-1-oro@il.ibm.com
Subject: [PATCH] block/rbd: Add support for rbd image encryption

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   8f860d2..53c5433  master     -> master
 * [new tag]         patchew/20210502073617.2978836-1-oro@il.ibm.com -> 
patchew/20210502073617.2978836-1-oro@il.ibm.com
Switched to a new branch 'test'
11af1d7 block/rbd: Add support for rbd image encryption

=== OUTPUT BEGIN ===
ERROR: "foo** bar" should be "foo **bar"
#51: FILE: block/rbd.c:355:
+        char** passphrase,

ERROR: "foo* bar" should be "foo *bar"
#94: FILE: block/rbd.c:398:
+                                              RbdEncryptionSpec* spec,

total: 2 errors, 0 warnings, 385 lines checked

Commit 11af1d704fbe (block/rbd: Add support for rbd image encryption) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210502073617.2978836-1-oro@il.ibm.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210502073617.2978836-1-oro@il.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com