qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tcg/ppc: Fix building with Clang


From: Brad Smith
Subject: Re: [PATCH] tcg/ppc: Fix building with Clang
Date: Sun, 2 May 2021 00:02:56 -0400
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Thunderbird/89.0

On 4/22/2021 11:39 AM, Richard Henderson wrote:
On 4/22/21 2:20 AM, Peter Maydell wrote:
On Thu, 22 Apr 2021 at 06:18, Richard Henderson
I'm thinking something like

#if !defined(_CALL_SYSV) && \
      !defined(_CALL_DARWIN) && \
      !defined(_CALL_AIX) && \
      !defined(_CALL_ELF)
# if defined(__APPLE__)
#  define _CALL_DARWIN
# elif defined(__ELF__) && TCG_TARGET_REG_BITS == 32
#  define _CALL_SYSV
# else
#  error "Unknown ABI"
# endif
#endif

Doesn't this also need some case that handles "64bit ppc clang which doesn't
define _CALL_anything" ?

Clang does define _CALL_ELF for ppc64:

 // ABI options.
 if (ABI == "elfv1")
   Builder.defineMacro("_CALL_ELF", "1");
 if (ABI == "elfv2")
   Builder.defineMacro("_CALL_ELF", "2");


Able to spin up a patch that you think is appropriate?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]