Re: [PATCH 2/3] hw/display/qxl: Constify VMStateDescription

[Laurent Vivier]

Le 13/03/2021 à 18:11, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/display/qxl.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 93907e82a33..2ba75637ec3 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -2384,7 +2384,7 @@ static bool qxl_monitors_config_needed(void *opaque)
>  }
>  
>  
> -static VMStateDescription qxl_memslot = {
> +static const VMStateDescription qxl_memslot = {
>      .name               = "qxl-memslot",
>      .version_id         = QXL_SAVE_VERSION,
>      .minimum_version_id = QXL_SAVE_VERSION,
> @@ -2396,7 +2396,7 @@ static VMStateDescription qxl_memslot = {
>      }
>  };
>  
> -static VMStateDescription qxl_surface = {
> +static const VMStateDescription qxl_surface = {
>      .name               = "qxl-surface",
>      .version_id         = QXL_SAVE_VERSION,
>      .minimum_version_id = QXL_SAVE_VERSION,
> @@ -2414,7 +2414,7 @@ static VMStateDescription qxl_surface = {
>      }
>  };
>  
> -static VMStateDescription qxl_vmstate_monitors_config = {
> +static const VMStateDescription qxl_vmstate_monitors_config = {
>      .name               = "qxl/monitors-config",
>      .version_id         = 1,
>      .minimum_version_id = 1,
> @@ -2425,7 +2425,7 @@ static VMStateDescription qxl_vmstate_monitors_config = 
> {
>      },
>  };
>  
> -static VMStateDescription qxl_vmstate = {
> +static const VMStateDescription qxl_vmstate = {
>      .name               = "qxl",
>      .version_id         = QXL_SAVE_VERSION,
>      .minimum_version_id = QXL_SAVE_VERSION,
> 

Applied to my trivial-patches branch.

Thanks,
Laurent