[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] migration: Deprecate redundant query-migrate result @blocked
From: |
Peter Maydell |
Subject: |
Re: [PATCH] migration: Deprecate redundant query-migrate result @blocked |
Date: |
Tue, 20 Apr 2021 12:50:56 +0100 |
On Tue, 20 Apr 2021 at 10:25, Dr. David Alan Gilbert
<dgilbert@redhat.com> wrote:
>
> * Daniel P. Berrangé (berrange@redhat.com) wrote:
> > On Tue, Apr 20, 2021 at 07:19:06AM +0200, Markus Armbruster wrote:
> > > Result @blocked is true when and only when result @blocked-reasons is
> > > present. It's always non-empty when present. @blocked is redundant.
> > > It was introduced in commit 3af8554bd0 "migration: Add blocker
> > > information", and has not been released. This gives us a chance to
> > > fix the interface with minimal fuss.
> > >
> > > Unfortunately, we're already too close to the release to risk dropping
> > > it. Deprecate it instead.
> > >
> > > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > > ---
> > > This is alternative to "[PATCH v2] migration: Drop redundant
> > > query-migrate result @blocked".
> > >
> > > qapi/migration.json | 9 +++++++--
> > > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Yes,
>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> Peter: Do you want to pick that up directly ?
Yep; applied to master for 6.0.
thanks
-- PMM