Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inline

From:	Richard Henderson
Subject:	Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h"
Date:	Mon, 19 Apr 2021 12:27:05 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote:

Rename set_pc() as mips_cpu_set_error_pc(), declare it inlined
and use it in cpu.c and op_helper.c.

Why "error_pc"? The usage in mips_cpu_set_pc certainly isn't in response toany kind of error...

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 01/30] target/mips: Simplify meson TCG rules, (continued)
- [PATCH v3 01/30] target/mips: Simplify meson TCG rules, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 02/30] target/mips: Move IEEE rounding mode array to new source file, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 03/30] target/mips: Move msa_reset() to new source file, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 04/30] target/mips: Make CPU/FPU regnames[] arrays global, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 05/30] target/mips: Optimize CPU/FPU regnames[] arrays, Philippe Mathieu-Daudé, 2021/04/19
  - Re: [PATCH v3 05/30] target/mips: Optimize CPU/FPU regnames[] arrays, Richard Henderson, 2021/04/19
- [PATCH v3 06/30] target/mips: Restrict mips_cpu_dump_state() to cpu.c, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 07/30] target/mips: Turn printfpr() macro into a proper function, Philippe Mathieu-Daudé, 2021/04/19
  - Re: [PATCH v3 07/30] target/mips: Turn printfpr() macro into a proper function, Richard Henderson, 2021/04/19
- [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h", Philippe Mathieu-Daudé, 2021/04/19
  - Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h", Richard Henderson <=
    - Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h", Philippe Mathieu-Daudé, 2021/04/19
    - Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h", Richard Henderson, 2021/04/20
- [PATCH v3 09/30] target/mips: Merge do_translate_address into cpu_mips_translate_address, Philippe Mathieu-Daudé, 2021/04/19
  - Re: [PATCH v3 09/30] target/mips: Merge do_translate_address into cpu_mips_translate_address, Richard Henderson, 2021/04/19
- [PATCH v3 10/30] target/mips: Extract load/store helpers to ldst_helper.c, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 11/30] meson: Introduce meson_user_arch source set for arch-specific user-mode, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 12/30] target/mips: Introduce tcg-internal.h for TCG specific declarations, Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 13/30] target/mips: Add simple user-mode mips_cpu_do_interrupt(), Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 14/30] target/mips: Add simple user-mode mips_cpu_tlb_fill(), Philippe Mathieu-Daudé, 2021/04/19
- [PATCH v3 15/30] target/mips: Move cpu_signal_handler definition around, Philippe Mathieu-Daudé, 2021/04/19

Prev by Date: Re: [PATCH v3 07/30] target/mips: Turn printfpr() macro into a proper function
Next by Date: [PATCH 00/14] hw(/block/)nvme: spring cleaning
Previous by thread: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h"
Next by thread: Re: [PATCH v3 08/30] target/mips: Declare mips_cpu_set_error_pc() inlined in "internal.h"
Index(es):
- Date
- Thread