[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 3/8] tests/acceptance/linux_ssh_mips_malta.py: drop identical setUp |
|
Date: |
Fri, 16 Apr 2021 19:46:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/16/21 5:43 PM, Cleber Rosa wrote:
> On Fri, Apr 16, 2021 at 07:26:05AM +0200, Philippe Mathieu-Daudé wrote:
>> On 4/15/21 11:51 PM, Cleber Rosa wrote:
>>> These tests' setUp do not do anything beyong what their base class do.
>>> And while they do decorate the setUp() we can decorate the classes
>>> instead, so no functionality is lost here.
>>
>> This is what I did first when adding this test, but it was not working,
>> so I had to duplicate it to each method. Did something change so now
>> this is possible?
>>
>
> It did, but quite a while ago:
>
>
> https://avocado-framework.readthedocs.io/en/87.0/releases/76_0.html#users-test-writers
OK, the test is older. Do you mind adding a comment?
"Since Avocado 76.0 we can decorate setUp() directly, ..."
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> It could have been updated much earlier, but, better late than never.
Sure :)
Thanks,
Phil.
[PATCH 4/8] tests/acceptance/migration.py: cancel test if migration is not supported, Cleber Rosa, 2021/04/15
[PATCH 5/8] tests/acceptance/cpu_queries.py: use the proper logging channels, Cleber Rosa, 2021/04/15