|
From: | Emanuele Giuseppe Esposito |
Subject: | Re: [RFC PATCH v2 02/11] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine |
Date: | Fri, 9 Apr 2021 18:07:53 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
diff --git a/python/qemu/machine.py b/python/qemu/machine.py index c721e07d63..18d32ebe45 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -109,7 +109,7 @@ def __init__(self, self._binary = binary self._args = list(args) - self._wrapper = wrapper + self._wrapper = list(wrapper)Unrelated change?(I'm assuming you want to copy the user's input to explicitly avoid sharing state. Commit message blurb for this would be good.)
Yes, unrelated change. I do not see the benefit of copying the user state. I will drop it.
ACK
(Apologies for the ignorance, is this an Acked-by?) Emanuele
[Prev in Thread] | Current Thread | [Next in Thread] |