Re: [PATCH 18/24] DAX/unmap virtiofsd: Parse unmappable elements

[Stefan Hajnoczi]

On Thu, Feb 25, 2021 at 10:19:31AM +0000, Dr. David Alan Gilbert wrote:
> * Stefan Hajnoczi (stefanha@redhat.com) wrote:
> > On Tue, Feb 09, 2021 at 07:02:18PM +0000, Dr. David Alan Gilbert (git) 
> > wrote:
> > > diff --git a/tools/virtiofsd/fuse_common.h b/tools/virtiofsd/fuse_common.h
> > > index a090040bb2..ed9280de91 100644
> > > --- a/tools/virtiofsd/fuse_common.h
> > > +++ b/tools/virtiofsd/fuse_common.h
> > > @@ -611,6 +611,13 @@ enum fuse_buf_flags {
> > >       * detected.
> > >       */
> > >      FUSE_BUF_FD_RETRY = (1 << 3),
> > > +
> > > +    /**
> > > +     * The addresses in the iovec represent guest physical addresses
> > > +     * that can't be mapped by the daemon process.
> > > +     * IO must be bounced back to the VMM to do it.
> > > +     */
> > > +    FUSE_BUF_PHYS_ADDR = (1 << 4),
> > 
> > With a vIOMMU it's an IOVA. Without a vIOMMU it's a GPA. This constant
> > may need to be renamed in the future, but it is okay for now.
> 
> Do we have any naming for something that's either a GPA or a IOVA?

I don't remember but I think the naming is confusing in core vhost code
too :). I just don't remember if it's called a "physical address" there.

Stefan

signature.asc
Description: PGP signature