[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 2/6] block/vdi: Don't assume that blocks are larger than V
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v6 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader |
Date: |
Tue, 30 Mar 2021 16:29:25 +0100 |
On Thu, Mar 25, 2021 at 12:29:37PM +0100, Paolo Bonzini wrote:
> From: David Edmondson <david.edmondson@oracle.com>
>
> Given that the block size is read from the header of the VDI file, a
> wide variety of sizes might be seen. Rather than re-using a block
> sized memory region when writing the VDI header, allocate an
> appropriately sized buffer.
>
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> Message-Id: <20210309144015.557477-3-david.edmondson@oracle.com>
> Acked-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/vdi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v6 0/6] coroutine rwlock downgrade fix, minor VDI changes, Paolo Bonzini, 2021/03/25
- [PATCH v6 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer, Paolo Bonzini, 2021/03/25
- [PATCH v6 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader, Paolo Bonzini, 2021/03/25
- Re: [PATCH v6 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader,
Stefan Hajnoczi <=
- [PATCH v6 3/6] coroutine-lock: Store the coroutine in the CoWaitRecord only once, Paolo Bonzini, 2021/03/25
- [PATCH v6 4/6] coroutine-lock: Reimplement CoRwlock to fix downgrade bug, Paolo Bonzini, 2021/03/25
- [PATCH v6 6/6] test-coroutine: Add rwlock downgrade test, Paolo Bonzini, 2021/03/25
- [PATCH v6 5/6] test-coroutine: Add rwlock upgrade test, Paolo Bonzini, 2021/03/25
- Re: [PATCH v6 0/6] coroutine rwlock downgrade fix, minor VDI changes, Stefan Hajnoczi, 2021/03/30