[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/xtensa: make xtensa_modules static on import
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] target/xtensa: make xtensa_modules static on import |
|
Date: |
Tue, 30 Mar 2021 14:11:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/30/21 9:30 AM, Max Filippov wrote:
> xtensa_modules variable defined in each xtensa-modules.c.inc is only
> used locally by the including file. Make it static.
>
Reported-by: Yury Gribov <tetra2005@gmail.com>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/xtensa/import_core.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/xtensa/import_core.sh b/target/xtensa/import_core.sh
> index f3404039cc20..53d3c4d099bb 100755
> --- a/target/xtensa/import_core.sh
> +++ b/target/xtensa/import_core.sh
> @@ -35,6 +35,7 @@ tar -xf "$OVERLAY" -O binutils/xtensa-modules.c | \
> -e '/^#include "ansidecl.h"/d' \
> -e '/^Slot_[a-zA-Z0-9_]\+_decode (const xtensa_insnbuf
> insn)/,/^}/s/^ return 0;$/ return XTENSA_UNDEFINED;/' \
> -e 's/#include <xtensa-isa.h>/#include "xtensa-isa.h"/' \
> + -e 's/^\(xtensa_isa_internal xtensa_modules\)/static \1/' \
> > "$TARGET"/xtensa-modules.c.inc
>
> cat <<EOF > "${TARGET}.c"
>