Re: [PATCH for 6.0-rc2? v1 0/6] check-tcg for non-x86 hosts

[no-reply]

Patchew URL: 
20210329110303.15235-1-alex.bennee@linaro.org/">https://patchew.org/QEMU/20210329110303.15235-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210329110303.15235-1-alex.bennee@linaro.org
Subject: [PATCH for 6.0-rc2? v1 0/6] check-tcg for non-x86 hosts

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210329110303.15235-1-alex.bennee@linaro.org -> 
patchew/20210329110303.15235-1-alex.bennee@linaro.org
Switched to a new branch 'test'
80c8848 tests/i386/test-i386: try and correct constrain 16 bit call (WIP)
4288d31 tests/tcg/i386: expand .data sections for system tests
0f797f0 tests/tcg/configure.sh: make sure we pick up x86_64 cross compilers
2049387 tests/tcg: add concept of container_hosts
24cf690 tests/docker: don't set DOCKER_REGISTRY on non-x86_64
399a62b tests/tcg: update the defaults for x86 compilers

=== OUTPUT BEGIN ===
1/6 Checking commit 399a62bdaede (tests/tcg: update the defaults for x86 
compilers)
2/6 Checking commit 24cf690e3b06 (tests/docker: don't set DOCKER_REGISTRY on 
non-x86_64)
3/6 Checking commit 204938792670 (tests/tcg: add concept of container_hosts)
WARNING: line over 80 characters
#145: FILE: tests/tcg/configure.sh:290:
+              echo "DOCKER_CROSS_CC_GUEST=$container_cross_cc" >> 
$config_target_mak

total: 0 errors, 1 warnings, 119 lines checked

Patch 3/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/6 Checking commit 0f797f01c762 (tests/tcg/configure.sh: make sure we pick up 
x86_64 cross compilers)
5/6 Checking commit 4288d31858fd (tests/tcg/i386: expand .data sections for 
system tests)
6/6 Checking commit 80c884804e4a (tests/i386/test-i386: try and correct 
constrain 16 bit call (WIP))
ERROR: spaces required around that ':' (ctx:VxW)
#39: FILE: tests/tcg/i386/test-i386.c:1395:
+                  : "i" (MK_SEL(1)), "Ts" (&code16_func1): "memory", "cc");
                                                          ^

ERROR: spaces required around that ':' (ctx:VxW)
#44: FILE: tests/tcg/i386/test-i386.c:1399:
+                  : "i" (MK_SEL(1)), "Ts" (&code16_func2): "memory", "cc");
                                                          ^

ERROR: spaces required around that ':' (ctx:VxW)
#49: FILE: tests/tcg/i386/test-i386.c:1403:
+                  : "i" (MK_SEL(1)), "Ts" (&code16_func3): "memory", "cc");
                                                          ^

total: 3 errors, 0 warnings, 18 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210329110303.15235-1-alex.bennee@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210329110303.15235-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com