qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v12 49/65] target/arm: move TCG gt timer creation code in tcg/


From: Richard Henderson
Subject: Re: [RFC v12 49/65] target/arm: move TCG gt timer creation code in tcg/
Date: Sun, 28 Mar 2021 11:54:56 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 3/26/21 1:36 PM, Claudio Fontana wrote:
we need to be careful not to use

if (tcg_enabled())

here, because of the VMSTATE definitions in machine.c,
which are only protected by CONFIG_TCG, and thus
it would break the --enable-tcg --enable-kvm build.

Signed-off-by: Claudio Fontana<cfontana@suse.de>
---
  target/arm/tcg/tcg-cpu.h        |  1 +
  target/arm/cpu.c                | 28 +++--------------------
  target/arm/tcg/sysemu/tcg-cpu.c | 40 +++++++++++++++++++++++++++++++++
  3 files changed, 44 insertions(+), 25 deletions(-)

A little bit surprising this, but ok.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]